decentraland / comms-gatekeeper / 28373235419

85%

push

github

fix: preserve stored IP/device on null upsert of player connection info (#275)

* fix: preserve stored IP/device on null upsert of player connection info

The player_connection_info upsert overwrote ip_address and device_id
unconditionally on conflict, so any token request arriving without an
IP/device (e.g. a path that omits the identifier, or an older client)
would erase a value a later device/IP ban relies on. Scene-comms token
requests are frequent, making this likely in practice.

COALESCE each column against the existing row so a null incoming value
keeps the stored one, while a non-null value still overwrites. Columns
are preserved independently; updated_at keeps advancing as last-seen.

Add integration coverage for preserve-on-null, preserve-on-empty, and
per-column independence (new IP, absent device).

* docs: correct upsertPlayerConnection JSDoc for preserve-on-null behavior

The interface doc said subsequent calls overwrite the IP and device id,
which is no longer accurate after switching to COALESCE. Describe that a
null incoming value preserves the stored one per-column, while updated_at
always advances.

1105 of 1419 branches covered (77.87%)

Branch coverage included in aggregate %.

3042 of 3440 relevant lines covered (88.43%)

75.56 hits per line