curationexperts / cypripedium

99%

main: 99%

LAST BUILD ON BRANCH remove_execption_flow

branch: remove_execption_flow

CHANGE BRANCH

x

Reset

• remove_execption_flow
• add_coveralls
• aws_tags
• bag_refactor
• bootstrap4
• bs4_draft
• cap_changes
• capistrano
• code_climate
• collection_sort
• creator_order
• dependabot/bundler/actionview-7.2.3.1
• dependabot/bundler/activerecord-7.2.2.2
• dependabot/bundler/activestorage-7.2.2.2
• dependabot/bundler/activestorage-7.2.3.1
• dependabot/bundler/activesupport-7.2.3.1
• dependabot/bundler/aws-sdk-s3-1.208.0
• dependabot/bundler/bcrypt-3.1.22
• dependabot/bundler/devise-5.0.3
• dependabot/bundler/faraday-2.14.1
• dependabot/bundler/google-protobuf-3.25.5
• dependabot/bundler/json-2.10.2
• dependabot/bundler/net-imap-0.5.6
• dependabot/bundler/net-imap-0.5.7
• dependabot/bundler/nokogiri-1.18.3
• dependabot/bundler/nokogiri-1.18.4
• dependabot/bundler/nokogiri-1.18.8
• dependabot/bundler/nokogiri-1.18.9
• dependabot/bundler/nokogiri-1.19.1
• dependabot/bundler/rack-2.2.13
• dependabot/bundler/rack-2.2.14
• dependabot/bundler/rack-2.2.18
• dependabot/bundler/rack-2.2.19
• dependabot/bundler/rack-2.2.20
• dependabot/bundler/rack-2.2.22
• dependabot/bundler/rexml-3.4.2
• dependabot/bundler/thor-1.4.0
• dependabot/bundler/uri-1.0.3
• dependabot/bundler/uri-1.0.4
• deployment_woes
• envioronment-badge
• environment_badge
• fix_binstubs
• fix_citation_date_error
• fix_collection_link
• fix_create_work
• fix_create_work_button
• fix_deploy
• fix_flaky_test
• fix_report_download
• fix_searches
• fix_sort_and_per_page
• h5_patch_update_redux
• handle_deprecations
• hyrax_3x_latest
• hyrax_51
• hyrax_51_rc2
• initial_h5_redux
• json_creators
• json_views
• main
• parallelism_test
• patch_upgrade
• patch_upgrade2
• pre-xray-rails-upgrade
• production_tuning
• rack_mini_profiler
• remove_content_dm
• remove_contentdm
• remove_creator_migration
• remove_dead_code
• semantic_logging
• simplify_fits
• stats
• update_badge
• update_jquery
• update_readme
• upgrade_cleanup
• upgrade_hyrax5
• v5.8.0-for-load
• wip_creator_views

Build # c3247b30-ca6f-4433-8047-a7261b6defc4

Build Type

Pull #749

circleci

Committed by mark-dce

Commit Message

Override Hyrax code that relies on exception-based flow control

**ISSUE**
Significant numbers of exctptions were appearing in the log because
the attribute renderer and citation partial used on most pages
rely on exception based flow control.

* https://github.com/samvera/hyrax/blob/hyrax-v5.1.0/app/presenters/hyrax/presents_attributes.rb#L55
* https://github.com/samvera/hyrax/blob/hyrax-v5.1.0/app/views/shared/_citations.html.erb#L8

**RESOLUTION**
Refactor the code to avoid exception based flow control and override
locally until and upstream fix can be released.

Pull Request Pull Request #749: Override Hyrax code that relies on exception-based flow control

Coverage Stats

19 of 22 new or added lines in 3 files covered. (86.36%)

1194 of 1211 relevant lines covered (98.6%)

16.85 hits per line