curationexperts / cypripedium

98%

main: 99%

LAST BUILD ON BRANCH fix_sort_and_per_page

branch: fix_sort_and_per_page

CHANGE BRANCH

x

Reset

• fix_sort_and_per_page
• add_coveralls
• bag_refactor
• bootstrap4
• bs4_draft
• cap_changes
• capistrano
• code_climate
• collection_sort
• creator_order
• dependabot/bundler/activerecord-7.2.2.2
• dependabot/bundler/activestorage-7.2.2.2
• dependabot/bundler/google-protobuf-3.25.5
• dependabot/bundler/json-2.10.2
• dependabot/bundler/net-imap-0.5.6
• dependabot/bundler/net-imap-0.5.7
• dependabot/bundler/nokogiri-1.18.3
• dependabot/bundler/nokogiri-1.18.4
• dependabot/bundler/nokogiri-1.18.8
• dependabot/bundler/nokogiri-1.18.9
• dependabot/bundler/rack-2.2.13
• dependabot/bundler/rack-2.2.14
• dependabot/bundler/rack-2.2.18
• dependabot/bundler/thor-1.4.0
• dependabot/bundler/uri-1.0.3
• deployment_woes
• fix_binstubs
• fix_citation_date_error
• fix_collection_link
• fix_create_work
• fix_create_work_button
• fix_flaky_test
• fix_searches
• h5_patch_update_redux
• handle_deprecations
• hyrax_3x_latest
• hyrax_51
• hyrax_51_rc2
• initial_h5_redux
• json_creators
• main
• parallelism_test
• patch_upgrade
• patch_upgrade2
• pre-xray-rails-upgrade
• production_tuning
• remove_content_dm
• remove_contentdm
• remove_creator_migration
• remove_dead_code
• semantic_logging
• simplify_fits
• stats
• update_badge
• update_readme
• upgrade_cleanup
• upgrade_hyrax5
• v5.8.0-for-load
• wip_creator_views

Build # a3774e1b-062b-4bd5-a8e0-9e1bfd26c814

Build Type

Pull #671

circleci

Committed by mark-dce

Commit Message

Fix flaky test

**ISSUE**
The test was failing because with some random seeds, the tests were
setting up collection types and persisting the default ID before
this test was run, and then deleting the database object corresponding
to the persisted id.

The error looked like this:
```
  1) Collections listing from homepage link displays only collections
     Failure/Error: click_on 'all_collections'

     ActionView::Template::Error:
       Couldn't find Hyrax::CollectionType with 'id'=2
     # ./spec/system/collection_link_spec.rb:37:in `block (3 levels) in <top (required)>'
     # ------------------
     # --- Caused by: ---
     # ActiveRecord::RecordNotFound:
     #   Couldn't find Hyrax::CollectionType with 'id'=2
     #   ./spec/system/collection_link_spec.rb:37:in `block (3 levels) in <top (required)>'
```

**RESOLUTION**
Force clean Fedora before running the test to eliminate mis-matches between
IDs and persisted objects.

Pull Request Pull Request #671: Fix flaky test

Run Details

1033 of 1049 relevant lines covered (98.47%)

10.29 hits per line