curationexperts / cypripedium

98%

main: 99%

LAST BUILD ON BRANCH fix_citation_date_error

branch: fix_citation_date_error

CHANGE BRANCH

x

Reset

• fix_citation_date_error
• add_coveralls
• bag_refactor
• bootstrap4
• bs4_draft
• cap_changes
• capistrano
• code_climate
• collection_sort
• creator_order
• dependabot/bundler/activerecord-7.2.2.2
• dependabot/bundler/activestorage-7.2.2.2
• dependabot/bundler/google-protobuf-3.25.5
• dependabot/bundler/json-2.10.2
• dependabot/bundler/net-imap-0.5.6
• dependabot/bundler/net-imap-0.5.7
• dependabot/bundler/nokogiri-1.18.3
• dependabot/bundler/nokogiri-1.18.4
• dependabot/bundler/nokogiri-1.18.8
• dependabot/bundler/nokogiri-1.18.9
• dependabot/bundler/rack-2.2.13
• dependabot/bundler/rack-2.2.14
• dependabot/bundler/thor-1.4.0
• dependabot/bundler/uri-1.0.3
• deployment_woes
• fix_binstubs
• fix_collection_link
• fix_create_work
• fix_create_work_button
• fix_flaky_test
• fix_searches
• fix_sort_and_per_page
• h5_patch_update_redux
• handle_deprecations
• hyrax_3x_latest
• hyrax_51
• hyrax_51_rc2
• initial_h5_redux
• json_creators
• main
• parallelism_test
• patch_upgrade
• patch_upgrade2
• pre-xray-rails-upgrade
• production_tuning
• remove_content_dm
• remove_contentdm
• remove_creator_migration
• remove_dead_code
• semantic_logging
• simplify_fits
• stats
• update_badge
• update_readme
• upgrade_cleanup
• upgrade_hyrax5
• v5.8.0-for-load
• wip_creator_views

Build # a09bf359-957f-4221-85a2-2737c9440834

Build Type

Pull #708

circleci

Committed by mark-dce

Commit Message

Fix handling of non-parseable creation dates

**ISSUE**
Some works were not displaying because the citation presenter code
was encountering unexpected values that could not successfully be
parsed. Unexpected date values resulted in an unhandled exceptions
instead of having graceful failure modes.

**RESOLUTION**
Add a test case reprensenting the data we saw in the live application
and refactor the code to handle unexpected values gracefully:
In this case, we use the deposit year if the creation date is missing
or can not be parsed.

Pull Request Pull Request #708: Fix handling of non-parseable creation dates

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

1050 of 1066 relevant lines covered (98.5%)

10.83 hits per line