curationexperts / cypripedium

98%

main: 99%

LAST BUILD ON BRANCH simplify_fits

branch: simplify_fits

CHANGE BRANCH

x

Reset

• simplify_fits
• add_coveralls
• bag_refactor
• bootstrap4
• bs4_draft
• cap_changes
• capistrano
• code_climate
• collection_sort
• creator_order
• dependabot/bundler/activerecord-7.2.2.2
• dependabot/bundler/activestorage-7.2.2.2
• dependabot/bundler/google-protobuf-3.25.5
• dependabot/bundler/json-2.10.2
• dependabot/bundler/net-imap-0.5.6
• dependabot/bundler/net-imap-0.5.7
• dependabot/bundler/nokogiri-1.18.3
• dependabot/bundler/nokogiri-1.18.4
• dependabot/bundler/nokogiri-1.18.8
• dependabot/bundler/nokogiri-1.18.9
• dependabot/bundler/rack-2.2.13
• dependabot/bundler/rack-2.2.14
• dependabot/bundler/rack-2.2.18
• dependabot/bundler/thor-1.4.0
• dependabot/bundler/uri-1.0.3
• deployment_woes
• fix_binstubs
• fix_citation_date_error
• fix_collection_link
• fix_create_work
• fix_create_work_button
• fix_flaky_test
• fix_searches
• fix_sort_and_per_page
• h5_patch_update_redux
• handle_deprecations
• hyrax_3x_latest
• hyrax_51
• hyrax_51_rc2
• initial_h5_redux
• json_creators
• main
• parallelism_test
• patch_upgrade
• patch_upgrade2
• pre-xray-rails-upgrade
• production_tuning
• remove_content_dm
• remove_contentdm
• remove_creator_migration
• remove_dead_code
• semantic_logging
• stats
• update_badge
• update_readme
• upgrade_cleanup
• upgrade_hyrax5
• v5.8.0-for-load
• wip_creator_views

Build # b6e4549f-771f-4e05-a890-2ddfed266c4a

Build Type

Pull #618

circleci

Committed by mark-dce

Commit Message

Simplify overrides for using FITS servlet

**ISSUE**
The application copied all of the Hydra::Works::CharacterizationService
class in order to conditionally override one line in the `#extract_metadata`
method:

```
  def extract_metadata(content)
    Hydra::FileCharacterization.characterize(content, file_name, tools) do |cfg|
      cfg[:fits] = Hydra::Derivatives.fits_path
    end
  end
```

Gets overriden if the FITS servled URL is configured
```
  def extract_metadata(content)
    if ENV['FITS_SERVLET_URL']
      Hydra::FileCharacterization.characterize(content, file_name, :fits_servlet)
    else
      Hydra::FileCharacterization.characterize(content, file_name, :fits) do |cfg|
        cfg[:fits] = Hydra::Derivatives.fits_path
      end
    end
  end
```

**RESOLUTION**
We can actually push the check for the servlet downstream and override less code by
modifying the `#command` method in the Hydra::FileCharacterization::Characterizers::Fits
characterizer class.

This allows us to specifically target and test only the code we want to modify,
without pulling extra methods or classes that we don't need (or want) to override.

Pull Request Pull Request #618: Simplify overrides for using FITS servlet

Run Details

9 of 9 new or added lines in 2 files covered. (100.0%)

1041 of 1061 relevant lines covered (98.11%)

8.07 hits per line