christophevg / yoker

85%

LAST BUILD ON BRANCH master

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• feature/1-async-agent
• feature/10-type-exports
• feature/14-plugin-system
• feature/14-skill-infrastructure
• feature/16-clevis-config
• feature/7-config-auto-discovery
• feature/9-expanduser-storage-path
• feature/async-agent-module
• feature/async-event-handler
• feature/async-migration-complete
• feature/async-only-agent
• feature/context-manager-refactor
• feature/context-overflow
• feature/docs-review-refactor
• feature/fix-issue-38-litellm-message-mutation
• feature/github-tool
• feature/m2-default-tools-behavior
• feature/maintenance/setup-uv-upgrade
• feature/make-tool
• feature/mbi-002-bootstrap
• feature/mbi-003-design-proposal
• feature/mbi-003-python-api
• feature/mbi-004-yoker-commands
• feature/mbi-006-phase1-backend-protocol
• feature/mbi-006-phase2-litellm-backend
• feature/mbi-007-session
• feature/protected-files
• feature/read-offset-limit
• feature/search-enhancements
• feature/ui-back-port
• feature/ui-separation-cleanup-and-docs
• feature/ui-separation-phase1
• feature/ui-separation-phase2
• feature/ui-separation-phase3
• feature/ui-separation-phase4
• feature/ui-separation-phase5
• feature/ui-separation-phase6
• feature/ui-separation-phase7
• feature/update-package-md
• fix/71-skill-injection-base-dir
• fix/context-persistence
• fix/error-message-quality
• fix/m5-tool-backends
• fix/plugin-skills-loading-warning
• fix/security-error-clean
• fix/tool-parsing-harmonization
• fix/windows-content-type-hang
• master
• v0.2.0
• v0.3.0
• v0.3.1
• v0.4.0

Build # 41650260721

Build Type

push

github

Committed by christophevg-agent

Commit Message

fix(tools): accept path-style make targets (slash in target name)

Target names like docs/html are valid GNU make targets but the make
tool rejected them: the target regex did not allow '/'. Widen the
class to include '/' and make the pattern a single public constant,
yoker.config.MAKE_TARGET_RE, shared by both the tool-side validation
and the allowed_env_vars key validation — pinned by an identity test
so the two cannot drift. The rejection message now states the allowed
character set.

Security surface unchanged: first char must still be alphanumeric
(no flag injection), shell metacharacters remain forbidden, and the
invocation stays a no-shell list-argv subprocess.

Docs: README features/section note, CHANGELOG Unreleased/Changed.
Tests: new config-level pattern tests (10) + 4 end-to-end make-tool
tests (make docs/html, slashed allowlist key, /etc/passwd rejected,
message text).

Gates: make check (format+lint+typecheck+test) green.

Reported from live use: an agent could not run a slashed Makefile
target.

🤖 Implemented together with Yoker.

Coverage Stats

3691 of 4662 branches covered (79.17%)

Branch coverage included in aggregate %.

10922 of 12608 relevant lines covered (86.63%)

0.87 hits per line