bradleyfalzon / gopherci

61%

master: 61%

LAST BUILD ON BRANCH push

branch: push

CHANGE BRANCH

x

Reset

• push
• analyser-composition
• build-summary
• builddb
• clone-path
• commit-comment
• debug
• disable-private
• docker
• docs-errors
• dominikh
• dual-comments
• error-handling
• failed-diff
• first-commit
• fix-goveralls
• fix-hardcoded
• gcppubsub
• godep
• gopherci-env
• gopherci.yml
• graceful
• ignore-gen
• integration-test
• logger
• master
• maxcommments
• memlimit
• msgs
• pr-reviews
• pr-reviews-default
• preflight
• pubsub-breaking
• pubsub-timeout
• refactor-analyser
• reference-failures
• refreader
• remove-accountid
• reporter
• requeue
• review-no-approve
• senderid
• show-env
• syncronize
• test
• various
• wbsecret
• webui

Build # 137

Build Type

push

travis-ci

Committed by bradleyfalzon

Commit Message

Support GitHub PushEvent

This is accomplished with a few refactors.

We no longer fetch the diff URL provided in a Pull Request event,
it was convenient, but it's not available in Pushes and we can
easily calculate it ourselves without the need for the extra
lookup. This was GitHub specific too, other providers may not have
provided that URL.

Analyse does need to process a Push differently than a Pull Request,
and this is managed by the EventType type.

We ignore the GitHub push event's Before SHA ref, during testing
force pushes, this would be the ref of the commit that's being
"overwritten" so it wouldn't exist when clonsed. Unlike a
non-forced push, where the commit exists after the clone. So instead
of using Before, we use After~len(Commits), so no matter how many
commits are being pushed, or whether the previous commit exists or
not, we should be able to process it.

Resolves #27.

Run Details

118 of 118 new or added lines in 4 files covered. (100.0%)

533 of 875 relevant lines covered (60.91%)

1.55 hits per line