bradleyfalzon / gopherci

58%

master: 61%

LAST BUILD ON BRANCH clone-path

branch: clone-path

CHANGE BRANCH

x

Reset

• clone-path
• analyser-composition
• build-summary
• builddb
• commit-comment
• debug
• disable-private
• docker
• docs-errors
• dominikh
• dual-comments
• error-handling
• failed-diff
• first-commit
• fix-goveralls
• fix-hardcoded
• gcppubsub
• godep
• gopherci-env
• gopherci.yml
• graceful
• ignore-gen
• integration-test
• logger
• master
• maxcommments
• memlimit
• msgs
• pr-reviews
• pr-reviews-default
• preflight
• pubsub-breaking
• pubsub-timeout
• push
• refactor-analyser
• reference-failures
• refreader
• remove-accountid
• reporter
• requeue
• review-no-approve
• senderid
• show-env
• syncronize
• test
• various
• wbsecret
• webui

Build # 98

Build Type

push

travis-ci

Committed by bradleyfalzon

Commit Message

Clone to import path in /home/bradleyf/go/src/

Currently we clone into $GOPATH/src/gopherci but any project that
imports sub packages in the same repository, would have those
dependencies go get'd (go got?).

If the project imported internal packages, those couldn't be built
at all with the error `use of internal package not allowed`.

This fix attempts to guess the import path, based on the URL by:

- Getting the base repo's HTML URL `https://github.com/owner/repo`
- Strippping the scheme `github.com/owner/repo`
- Docker or file system executer runs command with that as the
working directory
- All clones, tools etc, are then executed in the repositories
working directory, which should be $GOPATH/src/github.com/owner/repo

I'm not a big fan of this is done (just stripping the scheme), but
the only edge case I can forsee are those with vanity import paths,
and it's not clear how to handle them right now, potentially
automated or potentially it could be configuration option per repo.

The other edgecases will come if GitHub changes URL structure or
we support other providers where the import path is not clear, both
of which can be dealt with at the time.

Fixes #16.

Run Details

456 of 783 relevant lines covered (58.24%)

1.29 hits per line