bradleyfalzon / gopherci

59%

master: 61%

LAST BUILD ON BRANCH godep

branch: godep

CHANGE BRANCH

x

Reset

• godep
• analyser-composition
• build-summary
• builddb
• clone-path
• commit-comment
• debug
• disable-private
• docker
• docs-errors
• dominikh
• dual-comments
• error-handling
• failed-diff
• first-commit
• fix-goveralls
• fix-hardcoded
• gcppubsub
• gopherci-env
• gopherci.yml
• graceful
• ignore-gen
• integration-test
• logger
• master
• maxcommments
• memlimit
• msgs
• pr-reviews
• pr-reviews-default
• preflight
• pubsub-breaking
• pubsub-timeout
• push
• refactor-analyser
• reference-failures
• refreader
• remove-accountid
• reporter
• requeue
• review-no-approve
• senderid
• show-env
• syncronize
• test
• various
• wbsecret
• webui

Build # 294

Build Type

push

travis-ci

Committed by bradleyfalzon

Commit Message

.travis.yml to use go1.9rc1 to workaround gocoveralls bug

We're going to force Travis CI to use go1.9rc1 (ideally just
need Go 1.9+), because goveralls is failing because go list ./...
is failing because one vendored package uses github.com/Sirupsen/logrus
and another uses github.com/sirupsen/logrus.

can't load package: package github.com/bradleyfalzon/gopherci/vendor/github.com/docker/docker/pkg/term/windows: case-insensitive import collision: "github.com/bradleyfalzon/gopherci/vendor/github.co
m/Sirupsen/logrus" and "github.com/bradleyfalzon/gopherci/vendor/github.com/sirupsen/logrus"

Goveralls does this to get the list of packages to test, but as we
only test non-vendored packages, we can safely ignore them.

In Go 1.9+, go list (along with other tools) will ignore vendor
directories, thus working around this issue until dependencies
can consistently import logrus.

I'm not convinced this is the best solution at all, but it's
resolving the issue and I can move forward.

Run Details

918 of 1546 relevant lines covered (59.38%)

2.39 hits per line