bradleyfalzon / gopherci

62%

master: 61%

LAST BUILD ON BRANCH ignore-gen

branch: ignore-gen

CHANGE BRANCH

x

Reset

• ignore-gen
• analyser-composition
• build-summary
• builddb
• clone-path
• commit-comment
• debug
• disable-private
• docker
• docs-errors
• dominikh
• dual-comments
• error-handling
• failed-diff
• first-commit
• fix-goveralls
• fix-hardcoded
• gcppubsub
• godep
• gopherci-env
• gopherci.yml
• graceful
• integration-test
• logger
• master
• maxcommments
• memlimit
• msgs
• pr-reviews
• pr-reviews-default
• preflight
• pubsub-breaking
• pubsub-timeout
• push
• refactor-analyser
• reference-failures
• refreader
• remove-accountid
• reporter
• requeue
• review-no-approve
• senderid
• show-env
• syncronize
• test
• various
• wbsecret
• webui

Build # 158

Build Type

push

travis-ci

Committed by bradleyfalzon

Commit Message

Ignore issues in generated code, or vendored/testdata directories

We consider generated code, anything that appears to be generated
or is in a vendor/testdata directory. GopherCI uses
github.com/gopherci/isFileGenerated which mostly uses a function
provided by github.com/shurcooL/go.

In using isFileGenerated, it makes it difficult for a user to provide
additional files to be ignored, this would need to be implemented in
similar areas by other method if we decide to support that option.

This causes all issues from generated code to be ignored, there
will be no option to only comment, or only set the build to failed
as the issue will be ignored as soon as it's detected.

An additional integration test has been provided, because although
there are unit tests, it's possible the underlying tools misbehave
or change their implementation details.

Resolves #57.

Run Details

571 of 918 relevant lines covered (62.2%)

1.61 hits per line