bradleyfalzon / gopherci

57%

master: 61%

LAST BUILD ON BRANCH failed-diff

branch: failed-diff

CHANGE BRANCH

x

Reset

• failed-diff
• analyser-composition
• build-summary
• builddb
• clone-path
• commit-comment
• debug
• disable-private
• docker
• docs-errors
• dominikh
• dual-comments
• error-handling
• first-commit
• fix-goveralls
• fix-hardcoded
• gcppubsub
• godep
• gopherci-env
• gopherci.yml
• graceful
• ignore-gen
• integration-test
• logger
• master
• maxcommments
• memlimit
• msgs
• pr-reviews
• pr-reviews-default
• preflight
• pubsub-breaking
• pubsub-timeout
• push
• refactor-analyser
• reference-failures
• refreader
• remove-accountid
• reporter
• requeue
• review-no-approve
• senderid
• show-env
• syncronize
• test
• various
• wbsecret
• webui

Build # 233

Build Type

push

travis-ci

Committed by bradleyfalzon

Commit Message

Handle repositories with no history (eg new)

For a new repository, or a branch which doesn't have any history
(tracking a different git tree), we can't get a diff using the
"git diff abcd~5...abcd" method.

Instead, we'll try that way, and if it fails, try to get the diff
using "git show abcd".

I chose not to have the analyser check the ref "abcd~5" exists first
to help simplify the code, with less conditionals, but I'm not
convinced this is any more readable and potentially less reliable.
Therefore, it may be refactored in the future.

I've added an integration test for this as well, to ensure the
behaviour with git is always tested and not mocked like it is in the
unit test.

Fixes #79.

Run Details

780 of 1374 relevant lines covered (56.77%)

1.73 hits per line