bitcoindevkit / bdk-sp

26%

push

github

Merge bitcoindevkit/bdk-sp#62: test: refresh BIP-352 test vectors to v1.1.1

<a class=hub.com/bitcoindevkit/bdk-sp/commit/bcac0396b3519ed930ce2c186af52a495447b1d2">bcac0396b test: refresh BIP-352 test vectors to v1.1.1 (macgyver13)

Pull request description:

  ### Description

  Refresh BIP-352 test vectors to match version [1.1.1](https://github.com/bitcoin/bips/pull/2142)
  - Add tests 26 & 27 to send.rs and receive.rs.
  - Modify serialization to parse the updated sending.given.recipients map and maintain receiving.expected.addresses string format.

  ### Notes to the reviewers

  cargo t --test functional_tests bip352_vectors

  All tests pass - 3 are ignored for this PR
  ```
  test bip352_vectors::send::input_keys_intermediate_sum_is_zero_but_final_sum_is_non_zero ... ignored, currently fails due to intermediate sum being zero
  test bip352_vectors::send::maximum_per_group_recipient_limit_k_max_is_exceeded ... ignored, limit k-max not implemented
  test bip352_vectors::receive::maximum_per_group_recipient_limit_k_max_is_exceeded ... ignored, limit k-max not implemented
  ```

  Resolving ignored tests will be handled in future PRs.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [conventional commit guidelines](https://www.conventionalcommits.org/en/v1.0.0/)
  * [x] I ran `just p` (fmt, clippy and test) before committing

ACKs for top commit:
  nymius:
    ACK bcac0396b3519ed930ce2c186af52a495447b1d2

Tree-SHA512: ae04dfaec32f7ebc8269bc2c5f95baff40c

74 of 94 branches covered (78.72%)

Branch coverage included in aggregate %.

819 of 3278 relevant lines covered (24.98%)

10.21 hits per line