bitcoindevkit / bdk-sp / 33506098910

27%

push

github

Merge bitcoindevkit/bdk-sp#74: ci(mutants): build the baseline with --all-features

<a class=hub.com/bitcoindevkit/bdk-sp/commit/14e6cbe0bdd96ace54dd0b46d21ef01bc5db2755">14e6cbe0b ci(mutants): build the baseline with --all-features (kkdao)

Pull request description:

  The `Incremental mutants test` lane is currently dead: it fails at the unmutated baseline on every PR, so no mutants are ever tested. The last run on master, 783c63c9, is red for the same reason.

  Args after `--` are handed to the test phase only, so the baseline build runs with default features. `bdk_sp` gates `serde` behind an optional feature while its test scaffolding derives `Deserialize`, so the test targets do not compile without it and the build fails before mutation starts. Reproduces on a clean master worktree with `cargo check -p bdk_sp --tests`.

  Passing the feature through `--cargo-arg` fixes it, since that applies to every cargo invocation including the build. It also has to come out of the trailing args: `--cargo-arg` already adds it to the test command, and cargo rejects `--all-features` twice.

  Verified locally against the diff from #70, which previously died at the baseline:

  ```
  7 mutants tested in 83s: 6 caught, 1 unviable
  ```

  Unrelated, noted while here and left alone: this workflow has `on: push: branches: [main]` while the default branch is `master`, so that trigger never fires. The job is gated on `github.event_name == 'pull_request' anyway, so it changes nothing today.

ACKs for top commit:
  nymius:
    ACK 14e6cbe0bdd96ace54dd0b46d21ef01bc5db2755

Tree-SHA512: f72ac39a68ca8162a65c93d94da1b212f81

74 of 94 branches covered (78.72%)

Branch coverage included in aggregate %.

819 of 3278 relevant lines covered (24.98%)

10.32 hits per line