|
Ran
|
Jobs
1
|
Files
23
|
Run time
1min
|
Badge
README BADGES
|
push
github
Merge bitcoindevkit/bdk-sp#77: refactore(test): ignore slow tests locally during pre-push, still run them in CI <a class=hub.com/bitcoindevkit/bdk-sp/commit/6d61ce323d272711569c38e566462bd4701ec783">6d61ce323 refactore: ignore slow tests locally during pre-push (MusabYK) Pull request description: <!-- You can erase any parts of this template not applicable to your Pull Request. --> ### Description This is a follow up #75 ### Notes to the reviewers I group slow but correct/implemented tests under a nested mod slow { .. } block and add #[ignore]. This excludes them from local cargo test runs (just test/pre-push), but CI targets them all using a single filter: cargo test -- --ignored slow::. slow tests should now be added in mod slow{..} block in any file or crate. Also added `just test-slow` (alias just ts) and `just test-all` (alias just ta) since slow tests are still real tests someone may want to run before trusting a change. ### Changelog notice <!-- Notice the release manager should include in the release tag message changelog --> <!-- See https://keepachangelog.com/en/1.0.0/ for examples --> ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [conventional commit guidelines](https://www.conventionalcommits.org/en/v1.0.0/) * [x] I ran `just p` (fmt, clippy and test) before committing #### New Features: * [x] I've added tests for the new feature * [ ] I've added docs for the new feature #### Bugfixes: * [ ] This pull request breaks the existing API * [x] I've added tests to reproduce the issue which are now passing * [x] I'm linking the issue being fixed by this PR ACKs for top commit: nymius: ACK 6d61ce323d272711569c38e566462bd4701ec783 Tree-SHA512: 01f3398c765c88421696ae7acca05d96bf5
75 of 96 branches covered (78.13%)
Branch coverage included in aggregate %.
813 of 3153 relevant lines covered (25.78%)
9.99 hits per line
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 21 |
0.0 |
0.0% | cli/v1/src/main.rs |
| 14 |
0.0 |
0.0% | cli/v2/src/main.rs |
| 6 |
0.0 |
0.0% | indexer/src/v2/mod.rs |
| 2 |
60.71 |
-1.1% | silentpayments/src/receive/scan.rs |
| 2 |
0.0 |
0.0% | wallet/src/lib.rs |
| 1 |
76.3 |
-1.29% | silentpayments/src/receive/mod.rs |
| 1 |
28.57 |
-1.06% | silentpayments/src/send/error.rs |
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 34081301384.1 | 23 |
27.33 |
GitHub Action Run |
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
|---|