bitcoindevkit / bdk-sp / 33665478528

27%

push

github

Merge bitcoindevkit/bdk-sp#66: fix: return an error for empty silent payment payloads

<a class=hub.com/bitcoindevkit/bdk-sp/commit/582ff44280a1287189637271a3eb4ef5376f3656">582ff4428 fix: return an error for empty silent payment payloads (Matthew)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  Generic Bech32m permits an empty payload, but `SilentPaymentCode::try_from` assumes the decoded payload contains a version and panics when it does not. This returns `WrongPayloadLength` instead and adds regression coverage.

  ### Notes to the reviewers

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  ### Changelog notice

  Return an error instead of panicking when parsing a silent payment code with an empty payload.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [conventional commit guidelines](https://www.conventionalcommits.org/en/v1.0.0/)
  * [x] I ran `just p` (fmt, clippy and test) before committing

  #### New Features:

  * [x] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  nymius:
    ACK 582ff44280a1287189637271a3eb4ef5376f3656

Tree-SHA512: 815ea4b5585d87a1d5a425dd99f0df99d42

74 of 94 branches covered (78.72%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

843 of 3303 relevant lines covered (25.52%)

10.58 hits per line