bitcoindevkit / bdk-sp / 33765353364

27%

push

github

Merge bitcoindevkit/bdk-sp#75: fix(receive): Enforce BIP-352 K_MAX per-group recipient limit in scan_txouts

<a class=hub.com/bitcoindevkit/bdk-sp/commit/1598b066ca880debafeeafce894500a3ee925969">1598b066c fix: enforce K_max limit during tx scan and unignore test 27 (MusabYK)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->
  Fixes #67  by adding const K_MAX: u32 = 2323 to silentpayments::receive, and a threshold check to the matched_tweaks counter loop in scan_txouts. Also added a ScanLimitExceeded(u32) variant to SpReceiveError returning an explicit error
  ### Notes to the reviewers
  I replaced `check_cases(27)` with a dedicated
  `maximum_per_group_recipient_limit_k_max_is_exceeded()` test function that explicitly matches and asserts SpReceiveError::ScanLimitExceeded(K_MAX) on test vector 27, preserving `check_cases` for standard test vectors. i think modifying it with hardcoded branch conditions for test 27 makes the general test runner dirty.
  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [conventional commit guidelines](https://www.conventionalcommits.org/en/v1.0.0/)
  * [x] I ran `just p` (fmt, clippy and test) before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  nymius:
    ACK 1598b066ca880debafeeafce894500a3ee925969

Tree-SHA512: d8d5a93dbd3321b4a70444a1ba8fda5af31

76 of 96 branches covered (79.17%)

Branch coverage included in aggregate %.

3 of 5 new or added lines in 2 files covered. (60.0%)

845 of 3307 relevant lines covered (25.55%)

6988.84 hits per line