GrottoCenter / grottocenter-api
87%
develop: 91%

Repo Added 31 Jul 2022 03:11PM UTC

Committed 25 Aug 2026 07:49PM UTC coverage: 87.334% (-0.01%) from 87.345%

Committed by

Commit Message

fix(document): address code review findings

- P1: add DocumentService.clearParentIfTypeDisallows() helper and call
  it in update-with-new-entities.js so both update paths enforce the
  same type-vs-parent policy (stale parent cleared on type change)
- P2: migration now uses DROP CONSTRAINT IF EXISTS + ADD NOT VALID +
  VALIDATE CONSTRAINT for idempotency and safe application over
  pre-existing corrupt rows
- P2: guard checkParentCycle() call sites with Number.isFinite() to
  prevent a NaN false-negative when ids are non-numeric
- P3: TYPES_REQUIRING_PARENT is now an alias of TYPES_ALLOWING_PARENT
  with a comment explaining the equivalence
- P3: rename misleading test title to reflect actual assertion

Coverage Stats

5198 of 6242 branches covered (83.27%)

Branch coverage included in aggregate %.

41 of 47 new or added lines in 5 files covered. (87.23%)

9565 of 10662 relevant lines covered (89.71%)

141.78 hits per line

10662 RELEVANT LINES 9565 COVERED LINES

141.78 HITS PER LINE

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
32891860245	fix/document-cyclic-parent	fix(document): address code review findings - P1: add DocumentService.clearParentIfTypeDisallows() helper and call it in update-with-new-entities.js so both update paths enforce the same type-vs-parent policy (stale parent cleared on type cha...	Pull #1779	25 Aug 2026 07:52PM UTC	ClemRz	github	87.33
32775339855	fix/document-cyclic-parent	fix(document): address code review findings - P1: add DocumentService.clearParentIfTypeDisallows() helper and call it in update-with-new-entities.js so both update paths enforce the same type-vs-parent policy (stale parent cleared on type cha...	Pull #1779	24 Aug 2026 08:44PM UTC	ClemRz	github	87.32
32745063391	fix/document-cyclic-parent	fix(document): address code review findings - P1: add DocumentService.clearParentIfTypeDisallows() helper and call it in update-with-new-entities.js so both update paths enforce the same type-vs-parent policy (stale parent cleared on type cha...	Pull #1779	24 Aug 2026 03:30PM UTC	ClemRz	github	87.3
32528685580	fix/document-cyclic-parent	fix(document): address code review findings - P1: add DocumentService.clearParentIfTypeDisallows() helper and call it in update-with-new-entities.js so both update paths enforce the same type-vs-parent policy (stale parent cleared on type cha...	Pull #1779	21 Aug 2026 09:31PM UTC	ClemRz	github	87.24
32286584132	fix/document-cyclic-parent	fix(document): address code review findings - P1: add DocumentService.clearParentIfTypeDisallows() helper and call it in update-with-new-entities.js so both update paths enforce the same type-vs-parent policy (stale parent cleared on type cha...	Pull #1779	19 Aug 2026 06:20PM UTC	ClemRz	github	87.19
32198056261	fix/document-cyclic-parent	fix(document): prevent cyclic parent relationships - Add CHECK constraint (id <> id_parent) to t_document to block self-references at the DB level; mirrored in test/customSQL.js - Add DocumentService.checkParentCycle() using a cycle-safe CTE ...	Pull #1779	18 Aug 2026 11:41PM UTC	ClemRz	github	87.29
32197814718	fix/document-cyclic-parent	fix(document): prevent cyclic parent relationships - Add CHECK constraint (id <> id_parent) to t_document to block self-references at the DB level; mirrored in test/customSQL.js - Add DocumentService.checkParentCycle() using a cycle-safe CTE ...	push	18 Aug 2026 11:37PM UTC	ClemRz	github	87.3

GrottoCenter / grottocenter-api
87%
develop: 91%

GrottoCenter / grottocenter-api 87% develop: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on fix/document-cyclic-parent

Recent builds

GrottoCenter / grottocenter-api
87%
develop: 91%

README BADGES
x

CHANGE BRANCH
x