GrottoCenter / grottocenter-api / 32775339855

87%

develop: 91%

Pull #1779

github

fix(document): address code review findings

- P1: add DocumentService.clearParentIfTypeDisallows() helper and call
  it in update-with-new-entities.js so both update paths enforce the
  same type-vs-parent policy (stale parent cleared on type change)
- P2: migration now uses DROP CONSTRAINT IF EXISTS + ADD NOT VALID +
  VALIDATE CONSTRAINT for idempotency and safe application over
  pre-existing corrupt rows
- P2: guard checkParentCycle() call sites with Number.isFinite() to
  prevent a NaN false-negative when ids are non-numeric
- P3: TYPES_REQUIRING_PARENT is now an alias of TYPES_ALLOWING_PARENT
  with a comment explaining the equivalence
- P3: rename misleading test title to reflect actual assertion

5196 of 6242 branches covered (83.24%)

Branch coverage included in aggregate %.

41 of 47 new or added lines in 5 files covered. (87.23%)

9565 of 10662 relevant lines covered (89.71%)

141.9 hits per line