GrottoCenter / grottocenter-api / 32197814718

87%

develop: 91%

push

github

fix(document): prevent cyclic parent relationships

- Add CHECK constraint (id <> id_parent) to t_document to block
  self-references at the DB level; mirrored in test/customSQL.js
- Add DocumentService.checkParentCycle() using a cycle-safe CTE
  (PostgreSQL CYCLE clause) to detect indirect cycles before writes
- Fix getCollectionAncestors() with CYCLE clause so legacy/corrupt
  cyclic data can never hang the query (resolves org detail timeout)
- Add TYPES_ALLOWING_PARENT / TYPES_REQUIRING_PARENT constants and
  replace MANDATORY_PARENT_TYPES string array with constant IDs
- getConvertedDataFromClient() now explicitly sets parent to null
  when the resolved type does not allow a parent, preventing stale
  id_parent from surviving a type change (e.g. Issue → Collection)
- update.js: validate proposed parent for cycles before file upload
- update-with-new-entities.js: validate parent before transaction

Fixes #1778

5179 of 6222 branches covered (83.24%)

Branch coverage included in aggregate %.

12 of 19 new or added lines in 4 files covered. (63.16%)

9537 of 10635 relevant lines covered (89.68%)

140.99 hits per line