GrottoCenter / grottocenter-api / 32528685580

87%

develop: 91%

Build Type

Pull #1779

github

Committed by ClemRz

Commit Message

fix(document): address code review findings

- P1: add DocumentService.clearParentIfTypeDisallows() helper and call
  it in update-with-new-entities.js so both update paths enforce the
  same type-vs-parent policy (stale parent cleared on type change)
- P2: migration now uses DROP CONSTRAINT IF EXISTS + ADD NOT VALID +
  VALIDATE CONSTRAINT for idempotency and safe application over
  pre-existing corrupt rows
- P2: guard checkParentCycle() call sites with Number.isFinite() to
  prevent a NaN false-negative when ids are non-numeric
- P3: TYPES_REQUIRING_PARENT is now an alias of TYPES_ALLOWING_PARENT
  with a comment explaining the equivalence
- P3: rename misleading test title to reflect actual assertion

Pull Request Pull Request #1779: fix(document): prevent cyclic parent relationships

Coverage Stats

5184 of 6234 branches covered (83.16%)

Branch coverage included in aggregate %.

19 of 32 new or added lines in 4 files covered. (59.38%)

8 existing lines in 1 file now uncovered.

9544 of 10648 relevant lines covered (89.63%)

141.39 hits per line