GrottoCenter / grottocenter-api / 32286584132

87%

develop: 91%

Build Type

Pull #1779

github

Committed by ClemRz

Commit Message

fix(document): address code review findings

- P1: add DocumentService.clearParentIfTypeDisallows() helper and call
  it in update-with-new-entities.js so both update paths enforce the
  same type-vs-parent policy (stale parent cleared on type change)
- P2: migration now uses DROP CONSTRAINT IF EXISTS + ADD NOT VALID +
  VALIDATE CONSTRAINT for idempotency and safe application over
  pre-existing corrupt rows
- P2: guard checkParentCycle() call sites with Number.isFinite() to
  prevent a NaN false-negative when ids are non-numeric
- P3: TYPES_REQUIRING_PARENT is now an alias of TYPES_ALLOWING_PARENT
  with a comment explaining the equivalence
- P3: rename misleading test title to reflect actual assertion

Pull Request Pull Request #1779: fix(document): prevent cyclic parent relationships

Coverage Stats

5182 of 6236 branches covered (83.1%)

Branch coverage included in aggregate %.

17 of 33 new or added lines in 4 files covered. (51.52%)

18 existing lines in 3 files now uncovered.

9540 of 10649 relevant lines covered (89.59%)

141.6 hits per line