Freegle / Iznik
71%
master: 71%

LAST BUILD BRANCH: fix/myposts-old-posts-pinned-by-room-chat-9481-583
DEFAULT BRANCH: master
Repo Added
Files 1303
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix/myposts-old-posts-pinned-by-room-chat-9481-583
branch: SELECT
CHANGE BRANCH
x

coverage: 70.54% (+0.007%) from 70.533%
22427

Pull #826

circleci

edwh 
fix(myposts): age out old posts pinned active by unrelated shared-room chat

Years-old posts kept reappearing in a member's active My Posts (Discourse
9481/583). Verified in prod for the three posts the reporter named:
70022383/70023547 (Rejected, 2020, no outcome) show active; 70516224
(Rejected, 2020, Withdrawn outcome) correctly shows Old.

Root cause is NOT arrival-vs-date (their arrival already equals their 2020
date) and NOT pending. applyExpiry correctly flags all three as past expiry,
but the recentChat guard then keeps them active because it measured recency
with MAX(chat_rooms.latestmessage) - the whole room's last message. Freegle
user-to-user rooms are one long-lived room per pair of people, so any recent
message between the two users (here, 3 days ago, about something else) made
every old post they ever referenced in that room look "actively discussed".
The post-specific chat reference for all three was 2020. 70516224 only
escaped to Old via its separate Withdrawn outcome.

Fix: judge recency by the latest chat message that actually references the
post (MAX(chat_messages.date) WHERE refmsgid = the post), not the room's
overall last message. A genuinely active post still has a recent reference
and stays active (TestExpiredMessageWithRecentChatKeptActive, unchanged); an
old post whose discussion ended ages ago now ages out even if the shared
room is still busy.

Test: TestExpiredMessageHeldActiveByUnrelatedRoomChatAgedOut - old post +
recent room latestmessage + an OLD refmsgid reference must age out of active.
Fails on the old room-level query, passes on the per-post query.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Pull Request #826: fix(myposts): age out old posts pinned active by unrelated shared-room chat

11032 of 14664 branches covered (75.23%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

120292 of 171506 relevant lines covered (70.14%)

35.91 hits per line

Relevant lines Covered
171506 RELEVANT LINES 120292 COVERED LINES
35.91 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
22427 fix/myposts-old-posts-pinned-by-room-chat-9481-583 fix(myposts): age out old posts pinned active by unrelated shared-room chat Years-old posts kept reappearing in a member's active My Posts (Discourse 9481/583). Verified in prod for the three posts the reporter named: 70022383/70023547 (Rejected,... Pull #826 edwh circleci
70.54
22430 feature/multi-group-messages-join rework #814: keep messages_spatial one-row, group-filter via messages_groups JOIN Per design decision: do NOT make messages_spatial per-group. Keep it one row per message (UNIQUE(msgid)) and resolve group-filtered browse/search through a correlat... Pull #827 edwh circleci
83.1
22423 master Merge pull request #812 from Freegle/fix/log-history-group-filter-9672-3 fix(modtools): deduplicate member posting history when message has reposts (#9672) push web-flow circleci
70.53
22415 fix/log-history-group-filter-9672-3 Merge origin/master into fix/log-history-group-filter-9672-3 Resolve the GetUserMessageHistory conflict by combining both changes that touch that query: - this PR (#812): replace the fan-out LEFT JOIN messages_postings with a correlated subqu... Pull #812 edwh circleci
71.44
22411 master Merge pull request #823 from Freegle/feature/rippling-self-tuning ripple 12/12: self-tuning loop + geographic hotspot detection (advisory) [post-go-live] push web-flow circleci
70.74
22372 feature/bulk-offer-clearance feat(bulk-offer): never send bulk/clearance offers to LoveJunk LoveJunk's draft model is one item per post and can't represent a multi-item clearance, so bulk offers (messages with messages_bulk_items rows) must not be pushed at all. Add a NOT EX... Pull #618 edwh circleci
70.95
22369 feature/rippling-mod-location-changes Merge remote-tracking branch 'origin/master' into fix819 # Conflicts: # iznik-server-go/test/user_test.go Pull #819 edwh circleci
70.84
22348 feature/rippling-immediate-mails Merge origin/master into feature/rippling-immediate-mails Bring the branch up to date (30 commits behind). Master has since moved the spatial postcode tests to open-sea coordinates, fixing the LocationTest/LocationIdTest flake (real postcode data... Pull #771 edwh circleci
70.86
22345 feature/rippling-held-replies Merge origin/master into feature/rippling-held-replies Bring the branch up to date (30 behind); pulls in master's open-sea coordinates fix for the LocationTest/LocationIdTest spatial flake. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Pull #770 edwh circleci
70.86
22332 feature/rippling-single-group-posting feat(rippling): honest whereami hint while the composer ships ahead of rippling The single-group composer ships live (the multi-group picker is gone) ahead of rippling being switched on, to avoid carrying both code paths behind a flag. So the hin... Pull #822 edwh circleci
70.82
See All Builds (1256)