Freegle / Iznik / 28987

73%

master: 73%

Build Type

Pull #1196

circleci

Committed by edwh

Commit Message

fix(rippling): fixed-horizon analytics trends so recent days don't draw as decline

The sysadmin analytics trend series counted replies and takes EVER, so
recent days - which simply hadn't finished accruing - always drew as a
steep mechanical decline: taken outcomes are marked a mean of ~19 days
after the post enters rippling, so the taken-ever line fell to near zero
over the trailing fortnight regardless of reality, and reply-ever/mean-
replies sloped down over the trailing days.

- Trend KPIs now use fixed accrual horizons from reach creation:
  replies + mean replies within 36h (ReplyHorizonHours), taken within
  14 days (TakenHorizonDays). Every day is measured the same way, so a
  lower recent point is a real change.
- Each trend row carries replied_mature / taken_mature flags (false
  until the day's whole horizon has elapsed); the component feeds them
  to a Google Charts 'certainty' role so a still-provisional tail draws
  dashed/pale rather than as a decline. Chart titles + section copy name
  the windows.
- The Section 1 replied-36h clock moves from
  COALESCE(MIN(rippled arrival), MIN(origin arrival)) to
  rippling_reach.created_at: autorepost bumps messages_groups.arrival
  forward, which silently handed older posts ever-longer 36h windows
  (and it drops two correlated subqueries per post).

Verified against prod data: with fixed horizons the July "decline" in
reply rate shrinks from -28pts (ever) to a real -5pts, and the taken
cliff (72% -> 18%) disappears entirely.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Pull Request Pull Request #1196: fix(rippling): fixed-horizon analytics trends so recent days don't draw as decline

Coverage Stats

13475 of 17702 branches covered (76.12%)

Branch coverage included in aggregate %.

31 of 55 new or added lines in 2 files covered. (56.36%)

439 existing lines in 3 files now uncovered.

141373 of 194738 relevant lines covered (72.6%)

38.31 hits per line