Freegle / Iznik / 28965

73%

master: 73%

Build Type

Pull #1195

circleci

Committed by edwh

Commit Message

fix(retry): stop 504s triggering ten stacked retries of expensive requests

A 504 means the gateway gave up on a request the server was probably
still executing - usually an endpoint that is slow for everyone, not a
transient blip. The retry loop's ten attempts each stacked another full
copy of that work on the server (seen live on the sysadmin rippling
analytics tab: the retry loop kept ~10 heavyweight query sets running
against the DB while the user only ever saw one failure).

Retry a 504 once, after a 10s backoff instead of the usual attempt*1s,
then surface the failure.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Pull Request Pull Request #1195: fix(rippling): stop /rippling/analytics 504ing on the sysadmin KPIs

Coverage Stats

13484 of 17708 branches covered (76.15%)

Branch coverage included in aggregate %.

19 of 77 new or added lines in 2 files covered. (24.68%)

2 existing lines in 1 file now uncovered.

141365 of 194752 relevant lines covered (72.59%)

38.23 hits per line