Freegle / Iznik / 28959

73%

master: 73%

Build Type

Pull #1194

circleci

Committed by edwh

Commit Message

fix(rippling): gate held replies out of the My Posts reply list

GET /message/:id builds the message reply list (replies + replycount, which
backs the "My Posts" page) by selecting all Interested replies, but without
the rippling held-reply gate that every delivery channel honours. A reply
held pending rippling (rippling_held_replies, status <> 'released') therefore
showed to the poster there - replier name, snippet and count - while the chat
message list, poster email, push, and the chat-list badge/snippet/roster
(PR #927) all correctly withheld it.

Add the same NOT EXISTS gate to that query, unconditionally (a count/list
surface, matching the #927 gates), so a held reply stays hidden until the
post ripples to the replier and reappears once released. Reply-holding
itself is intended behaviour; this only stops the held reply leaking into
the own-posts view.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Pull Request Pull Request #1194: fix(rippling): gate held replies out of the My Posts reply list

Coverage Stats

13447 of 17667 branches covered (76.11%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 1 file covered. (100.0%)

204 existing lines in 11 files now uncovered.

141287 of 194631 relevant lines covered (72.59%)

38.21 hits per line