DanGould / rust-payjoin

85%

master: 85%

LAST BUILD ON BRANCH fix/cli-println-bip78-terminology

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• 24-name-audit
• 402-ref-audit
• 465-rm-relay-from-session-ctx
• access-control
• access-control-v2
• add-agents-md
• add-navigability-signposts
• additive-cli-features
• additive-danger-local-https
• ai-disclosure
• arc-sc
• async-standup-v2
• avoid-uih-naming
• bump-ohttp-relay-0.0.10
• bump-payjoin-0-21
• bump-payjoin-0.24.0
• bump-payjoin-cli-0-1-0
• bump-payjoin-directory-0.0.2
• check-fetch-status
• check-independent-features
• coderabbit-refine-exceptions
• coderabbit-review-drafts
• coderabbit-strip-noise
• complete-intourl
• contributing-readme
• dart-fetch-ohttp-keys
• demo-sender-fallback
• directory-mod
• doc-contrib-test
• dont-set-path
• dry-run/standup-comment-trigger
• ensure-no-original-psbt-keypath
• errant-url-endpoint
• explicit-err-conversions
• feat/1314
• feat/async-standup
• feat/standup-comment-trigger
• ffi-msrv-1.85.0
• fix-dlh
• fix-flaky-prune-test
• fix-output-substitution-import
• fix-send-resume
• fix-standup-syntax
• fix-test-flakiness
• fix-uri-ext-case
• fix/402-ref-audit
• fix/402-typestate-docs
• fix/794-msrv-clippy
• fix/cli-println-bip78-terminology
• fix/devshell-treefmt
• handle-post-err
• handle-recv-contribution-err-as-unavailable
• handle-v2-error
• handle-v2-error-generic
• hide-danger-local-https
• hide-pr-template-checklist
• into-url
• json-error
• lib-docs
• lint-1.85.0
• lint-docs
• master
• min-feerate-broadcast
• moddocs
• no-uni-mod-distinction
• ohttp-fallback
• ohttp-relay-intourl
• ohttp-reqs-refactor
• one-expiry-error
• only-try-preserving-privacy
• overnight/issue-1016
• overnight/issue-1258
• overnight/issue-1274
• overnight/issue-855
• payjoin-0.21.0
• payjoin-0.22.0
• payjoin-0.23.0
• payjoin-0.24.0
• payjoin-0.25.0
• payjoin-1.0.0-rc.0
• payjoin-1.0.0-rc.1
• payjoin-1.0.0-rc.2
• payjoin-directory-0-0-1
• payjoin-directory-0.0.2
• payjoin-mailroom-0.1.0
• payjoin-test-utils-0.0.0
• persist-ohttp-keys
• persist-payjoin
• pjos-to-0
• poll-no-pause
• pr-checklist
• prepare-psbt-by-copy
• propagate-config-err
• receive-error-heirarchy
• recv-err
• recv-state-transition-objects
• refactor-receiver
• refactor-sender
• refactor-wantsfeerange
• reply-json
• req-impl-visibility
• seal-state-trait
• sep-receive-errors
• separate-receive
• separate-send-errors
• separate-send-versions-p1
• separate-send-versions-p2-v2
• service-docker-compose
• service-multi-listener
• session4/issue-1227
• session4/issue-1276
• session4/issue-1300
• session4/issue-1374
• session4/issue-749
• session4/standup-v2
• session4/unify-short-id
• split-v1-psbt-contexts
• test-utils
• test-utils-no-bitcoind
• test-utils-redis-follow
• uniform-ohttp-payloads
• update-bip78
• url-no-idna
• v1-data-minimization
• v1-feature-flag
• v1-v2
• v1context-visibility
• workflow-build-deps

Build # 25372138050

Build Type

push

github

Committed by DanGould

Commit Message

Use BIP 78 spec terms in payjoin-cli prints

The CLI called the request to the receiver a "fallback request"
and the post-send tx info "Sent fallback transaction ...". The
request body is the Original PSBT in BIP 78 parlance, and the
fallback transaction is the signed original tx -- which we have
not sent at that point, only computed. Tighten the wording to
match the spec.

Also rename "Posted original proposal..." to "Posted Original
PSBT..." for the v2 sender path. The internal name "Original
Proposal" stays in BIP 77 (Original PSBT plus extra params); only
the user-facing print is changed.

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

11509 of 13526 relevant lines covered (85.09%)

396.38 hits per line