DanGould / rust-payjoin

61%

master: 84%

LAST BUILD ON BRANCH additive-danger-local-https

branch: additive-danger-local-https

CHANGE BRANCH

x

Reset

Sync Branches

• additive-danger-local-https
• 24-name-audit
• 402-ref-audit
• 465-rm-relay-from-session-ctx
• access-control
• access-control-v2
• add-agents-md
• add-navigability-signposts
• additive-cli-features
• ai-disclosure
• arc-sc
• async-standup-v2
• avoid-uih-naming
• bump-ohttp-relay-0.0.10
• bump-payjoin-0-21
• bump-payjoin-0.24.0
• bump-payjoin-cli-0-1-0
• bump-payjoin-directory-0.0.2
• check-fetch-status
• check-independent-features
• coderabbit-refine-exceptions
• coderabbit-review-drafts
• coderabbit-strip-noise
• complete-intourl
• contributing-readme
• directory-mod
• doc-contrib-test
• dont-set-path
• ensure-no-original-psbt-keypath
• errant-url-endpoint
• explicit-err-conversions
• feat/1314
• feat/async-standup
• ffi-msrv-1.85.0
• fix-dlh
• fix-flaky-prune-test
• fix-output-substitution-import
• fix-send-resume
• fix-standup-syntax
• fix-test-flakiness
• fix-uri-ext-case
• fix/402-ref-audit
• fix/402-typestate-docs
• fix/794-msrv-clippy
• fix/devshell-treefmt
• handle-post-err
• handle-recv-contribution-err-as-unavailable
• handle-v2-error
• handle-v2-error-generic
• hide-danger-local-https
• hide-pr-template-checklist
• into-url
• json-error
• lib-docs
• lint-1.85.0
• lint-docs
• master
• min-feerate-broadcast
• moddocs
• no-uni-mod-distinction
• ohttp-fallback
• ohttp-relay-intourl
• ohttp-reqs-refactor
• one-expiry-error
• only-try-preserving-privacy
• overnight/issue-1016
• overnight/issue-1258
• overnight/issue-1274
• overnight/issue-855
• payjoin-0.21.0
• payjoin-0.22.0
• payjoin-0.23.0
• payjoin-0.24.0
• payjoin-1.0.0-rc.0
• payjoin-1.0.0-rc.1
• payjoin-directory-0-0-1
• payjoin-directory-0.0.2
• persist-ohttp-keys
• persist-payjoin
• pjos-to-0
• poll-no-pause
• pr-checklist
• prepare-psbt-by-copy
• propagate-config-err
• receive-error-heirarchy
• recv-err
• recv-state-transition-objects
• refactor-receiver
• refactor-sender
• refactor-wantsfeerange
• reply-json
• req-impl-visibility
• seal-state-trait
• sep-receive-errors
• separate-receive
• separate-send-errors
• separate-send-versions-p1
• separate-send-versions-p2-v2
• service-docker-compose
• service-multi-listener
• session4/issue-1227
• session4/issue-1276
• session4/issue-1300
• session4/issue-1374
• session4/issue-749
• session4/standup-v2
• session4/unify-short-id
• split-v1-psbt-contexts
• test-utils
• test-utils-no-bitcoind
• test-utils-redis-follow
• uniform-ohttp-payloads
• update-bip78
• url-no-idna
• v1-data-minimization
• v1-feature-flag
• v1-v2
• v1context-visibility
• workflow-build-deps

Build # 12537462827

Build Type

push

github

Committed by DanGould

Commit Message

Make _danger-local-https feature additive

Instead of feature gating function params, which introduces the need for
similar feature gating in downstream code, feature gate individual
functions.

See: <https://doc.rust-lang.org/cargo/reference/features.html#feature-unification>

"Rust features should be *additive*. That is, enabling a feature should
not disable functionality, and it should usually be safe to enable any
combination of features"

Before this change `io::fetch_ohttp_keys` had two function signatures
and changed its signature based on the feature flag. I noticed downstream
that this creates a necessity to carry those flags mess into bindings
or else face compile issues under certain feature combinations.

`io` now enables the `v2` feature since it only contains methods for
fetching OHTTP keys which is only useful in V2. In the future perhaps
it will also include generic HTTP client behavior taking `Request` as
a parameter in which case it should not enable `v2`, because such
functionality would be useful in a V1 setting as well.

Run Details

7 of 16 new or added lines in 2 files covered. (43.75%)

15 existing lines in 1 file now uncovered.

2882 of 4695 relevant lines covered (61.38%)

974.53 hits per line