• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

IJHack / QtPass / 43724549194
96%

Build:
DEFAULT BRANCH: main
Ran 15 Nov 2026 02:40PM UTC
Jobs 1
Files 87
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

15 Nov 2026 02:28PM UTC coverage: 96.303% (+0.04%) from 96.267%
43724549194

push

github

web-flow
OTP field on the first line: never the password (#2190)

An entry's first line is taken out as the password before the loop that
runs isLineHidden(), which knows every form a TOTP seed comes in: a bare
otpauth:// line, an OTP:/TOTP: field, and any field whose value is an
otpauth URI. The first line got only a narrower "starts with otpauth://"
test, in four places: parse() (so no code was shown),
getPasswordForDisplay(), the panel's defence in depth, and the Ctrl+C
handler. An OTP:/TOTP: field written as the first line was therefore shown
as the password, copied by Ctrl+C and "Always copy", and gave no code,
while the same field one line further down was hidden and gave the code.

FileContent::isOtpLine() is now the one rule, isLineHidden()'s, and all
four places use it. parse() records the first line's OTP configuration as
it does further down (the URI, or the field's value), so the entry shows
its code. getPassword() still returns the line, for the edit dialog's
round trip. The password member and getPassword() docs say the CR of a
CRLF line end is gone (review of #2189).

Tests otpFieldOnTheFirstLineIsNotThePassword (tst_filecontent: field forms,
case, a URI-valued field, controls), passwordFromFileToClipboardSkipsOtpSecret
(Ctrl+C refuses the field forms) and otpUriAsPasswordIsNeverRendered (the
panel refuses a TOTP field as password). Putting each of the four places
back on the URI-only test fails a test. Finding 2PCB2RIU.

Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

14 of 14 new or added lines in 3 files covered. (100.0%)

8595 of 8925 relevant lines covered (96.3%)

596.18 hits per line

Jobs
ID Job ID Ran Files Coverage
1 43724549194.1 15 Nov 2026 02:40PM UTC 87
96.3
GitHub Action Run
Source Files on build 43724549194
  • Tree
  • List 87
  • Changed 5
  • Source Changed 4
  • Coverage Changed 4
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #43724549194
  • 11c883e1 on github
  • Prev Build on main (#43722495310)
  • Next Build on main (#43728208630)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc