IJHack / QtPass
64%

DEFAULT BRANCH: main
Repo Added
Files 88
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 64.257% (+1.4%) from 62.904%
32880739204

push

github

web-flow 
feat: native RFC 6238 TOTP, replacing the pass-otp shell-out (#1625)

* feat: implement native TOTP storage and generation for the OTP field

QtPass advertised OTP support, but it was only a shell-out to the
third-party pass-otp extension: RealPass::OtpGenerate ran `pass otp`,
ImitatePass::OtpGenerate was a stub, ConfigDialog disabled the feature
when the extension was missing and hid the checkbox entirely on Windows,
and updateOtpButtonVisibility() hid the toolbar action on Windows and
macOS. OTP therefore never worked on Windows, never worked in
gpg2/git-direct mode, and needed a Unix package most users lack.

Generate one-time passwords in-process instead, using only QtCore
(QMessageAuthenticationCode + QCryptographicHash), so no dependency is
added. The configuration is stored as an otpauth:// URI in the OTP
template field, and bare otpauth:// lines written by pass-otp are still
read for compatibility.

New modules, ported and trimmed from KeePassXC:

- Base32 (src/base32.*): RFC 4648 codec. Failure is an empty QByteArray
  rather than KeePassXC's QVariant-nullness idiom. Two fixes over the
  original: encode() no longer sign-extends bytes >= 0x80 (which
  corrupted neighbouring bytes of the 40-bit quantum), and decode()
  rejects impossible pad counts instead of returning wrong-length data.
- Totp (src/totp.*): RFC 6238, SHA-1/256/512 plus the Steam encoder.
  parse() returns std::optional<Settings> and validates everything, so
  Settings is valid by construction and generate() cannot fail — this
  replaces KeePassXC's "return the localized error string in place of
  the code, plus a bool* out-param" convention. Also fixes its modulus
  overflow at ten digits (pow() into a quint32), applies the digits and
  period clamps on every path, and rejects otpauth://hotp/, which
  KeePassXC would answer with a plausible-looking wrong code.
- OtpCodeWidget (src/otpcodewidget.*): the live row. Its refresh timer
  is a child of the widget it updates, so Pass... (continued)

409 of 502 new or added lines in 11 files covered. (81.47%)

38 existing lines in 6 files now uncovered.

4622 of 7193 relevant lines covered (64.26%)

56.35 hits per line

Relevant lines Covered
7193 RELEVANT LINES 4622 COVERED LINES
56.35 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
32880739204 main feat: native RFC 6238 TOTP, replacing the pass-otp shell-out (#1625) * feat: implement native TOTP storage and generation for the OTP field QtPass advertised OTP support, but it was only a shell-out to the third-party pass-otp extension: RealPas... push web-flow github
64.26
32879240496 feat_totp Merge aca3f47ed into 3f4b12cb0 Pull #1625 web-flow github
64.26
32878309850 feat_totp Merge 79a9b3435 into 3f4b12cb0 Pull #1625 web-flow github
64.25
32877107209 feat_totp Merge d0ca44ddb into 3f4b12cb0 Pull #1625 web-flow github
64.27
32872154665 feat_totp Merge b2233e119 into 3f4b12cb0 Pull #1625 web-flow github
64.25
31856062896 feat_totp Merge ed3af813b into 00df77cf5 Pull #1625 web-flow github
64.25
31854855567 feat_totp Merge 8d801e699 into 00df77cf5 Pull #1625 web-flow github
64.25
31852190586 feat_totp Merge 524f1eddc into 00df77cf5 Pull #1625 web-flow github
64.25
31851554849 feat_totp Merge 6a7629119 into 00df77cf5 Pull #1625 web-flow github
64.25
31851053622 ci/validate-release-macos-qt611 Merge 013cd351b into 00df77cf5 Pull #1630 web-flow github
62.9
See All Builds (2085)