IJHack / QtPass
93%

DEFAULT BRANCH: main
Repo Added
Files 117
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 92.861% (-0.007%) from 92.868%
38207346999

push

github

web-flow 
Init: changed recipients always reach the entries, or the user is told (#2017)

Init wrote the new .gpg-id and committed it before re-encrypting (#1685,
#1682); when that commit failed (a stale index.lock, a failing hook, no
Git identity) it stopped there. The list named the new recipients while
every entry stayed encrypted to the old ones: a person removed from the
list could still read everything, and only git's error said anything.

Now a failed .gpg-id commit still re-encrypts the entries to the new
recipients, without any Git step (no pull, no backup commit, no per-entry
commits, no push: each would fail the same way or publish a half-done
state), and ends with one message: the recipients were changed and the
entries re-encrypted, but nothing is committed or pushed yet; fix Git and
commit, or save the recipients again. If re-encryption fails too, the
message says the entries are still encrypted to the previous recipients.
The old list is not put back: with signing on, the generation record has
moved on and would refuse it as a rollback. With a working commit the
order is unchanged.

Init also refuses, writing nothing, while another re-encryption runs: the
new list would otherwise stand over entries left on the old recipients
with only a status-bar note.


Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d

Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

33 of 36 new or added lines in 2 files covered. (91.67%)

9170 of 9875 relevant lines covered (92.86%)

193.86 hits per line

Relevant lines Covered
9875 RELEVANT LINES 9170 COVERED LINES
193.86 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
38207346999 main Init: changed recipients always reach the entries, or the user is told (#2017) Init wrote the new .gpg-id and committed it before re-encrypting (#1685, #1682); when that commit failed (a stale index.lock, a failing hook, no Git identity) it stopp... push web-flow github
92.86
38206518921 fix/init-commit-failure Merge a743949b9 into 7168676ee Pull #2017 web-flow github
92.86
38206226267 main Executor: start child processes without a controlling terminal (#2016) Started from a terminal, QtPass's children inherited it: git asked for HTTPS credentials, and ssh for a passphrase or a host key, on that /dev/tty. The executor runs one comma... push web-flow github
92.87
38205719375 fix/init-commit-failure Merge f856cb937 into 66cf21e46 Pull #2017 web-flow github
92.86
38205408232 fix/child-new-session Merge 9a5747e01 into 66cf21e46 Pull #2016 web-flow github
92.87
38204843826 main Signed .gpg-id: no fallback past a removed folder list, no signature by another key (#2014) * Signed .gpg-id: no fallback past a removed folder list, no signature by another key Found while reviewing the same design in PyQtPass (annejan/PyQtPass... push web-flow github
92.86
38203881391 fix/gpgid-no-fallback Merge cf5515d74 into a34e18e35 Pull #2014 web-flow github
92.86
38203813656 main GpgIdGeneration: a folder line with a control character is malformed (#2015) fuzz_gpgid found a header that does not survive being written back (#2014's run): '# QtPass-GpgId-Folder: 7w]' ending in \r\r\n parsed to the folder '7w]\r' (parse() str... push web-flow github
92.88
38202962703 fix/gpgid-folder-control-chars Merge f9e40cdd8 into 63ec350cb Pull #2015 web-flow github
92.89
38201823603 fix/gpgid-no-fallback Merge a0e1013d6 into 63ec350cb Pull #2014 web-flow github
92.86
See All Builds (2569)