• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

IJHack / QtPass / 43728208630
96%

Build:
DEFAULT BRANCH: main
Ran 15 Nov 2026 03:18PM UTC
Jobs 1
Files 87
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

15 Nov 2026 03:08PM UTC coverage: 96.275% (-0.03%) from 96.303%
43728208630

push

github

web-flow
OTP field on the first line: only when it holds a seed (#2191)

#2190 made an entry's first line a TOTP secret whenever it read as an
OTP:/TOTP: field (isOtpLine(), the rule for body lines). Review found the
false positive: a real password that only starts like one, such as
"totp:Secr3t!", was then hidden, refused by Ctrl+C and "Always copy", and
its tail fed to the code generator. The first line is the password in the
pass format, so it needs a stricter test.

FileContent::isOtpPasswordLine() decides for the first line: a bare
otpauth:// line, a field whose value is an otpauth URI, or an OTP:/TOTP:
field whose value is written as a base32 seed: base32 letters and the
digits 2 to 7 only (either case; white space, dashes and "=" between or
after the groups), at least 16 of them, that Totp::isValid() takes.
Totp::parse() alone is too lenient for this (it drops punctuation and
reads 0, 1 and 8 as letters). parse(), getPasswordForDisplay(), the
panel's defence in depth and the Ctrl+C handler use it; body lines keep
isOtpLine(). A long password of letters and the digits 2 to 7 still reads
as a seed; the docs say so.

A second review caught that a first draft skipped only spaces, so a seed
grouped with dashes, a tab or a no-break space was shown and copied again;
those separators are skipped now.

Tests otpFieldOnTheFirstLineIsNotThePassword (seed forms incl. grouped,
dashed, tab, NBSP; controls totp:Secr3t!, OTP: hunter2!, a short
ABCDEFGH, a seed with 0), passwordFromFileToClipboardSkipsOtpSecret and
otpUriAsPasswordIsNeverRendered (the controls are copied and shown as
the password). Dropping the seed test, its character check, its length
check, the separator handling, or putting any of the four places back on
isOtpLine() fails a test. Follow-up FU-2190 from the #2190 review.

Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

19 of 19 new or added lines in 3 files covered. (100.0%)

3 existing lines in 1 file now uncovered.

8607 of 8940 relevant lines covered (96.28%)

596.56 hits per line

Coverage Regressions

Lines Coverage ∆ File
3
93.22
-2.54% src/nativegrep.cpp
Jobs
ID Job ID Ran Files Coverage
1 43728208630.1 15 Nov 2026 03:18PM UTC 87
96.28
GitHub Action Run
Source Files on build 43728208630
  • Tree
  • List 87
  • Changed 5
  • Source Changed 4
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #43728208630
  • 28e30822 on github
  • Prev Build on main (#43724549194)
  • Next Build on main (#43731032207)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc