• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

IJHack / QtPass / 43722495310
96%

Build:
DEFAULT BRANCH: main
Ran 15 Nov 2026 02:19PM UTC
Jobs 1
Files 87
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

15 Nov 2026 02:06PM UTC coverage: 96.267% (-0.001%) from 96.268%
43722495310

push

github

web-flow
CRLF entries: the password is the first line without its carriage return (#2189)

* CRLF entries: the password is the first line without its "\r"

The password is the first line of the decrypted text, and both places that
take that line cut it at "\n" only: FileContent::parse() and the Ctrl+C
handler passwordFromFileToClipboard(). For an entry saved with CRLF line
ends (a Windows file inserted with pass insert -m, say) the password was
"hunter2\r": Ctrl+C and "Always copy" put the carriage return on the
clipboard, while the password row (which drops it since #2149) showed and
copied "hunter2". The edit dialog loaded the CR into the password field,
so a character typed at the end was saved behind it ("hunter2\r!"), and
from then on every copy path handed out a password the user never typed.

FileContent::passwordLine() is now the one rule: the first line, a
trailing "\r" dropped. parse() and the Ctrl+C handler use it. The edit
dialog keeps the CR out of the password field and writes it back after the
field, so a save keeps the entry's line ends and an unedited save is still
byte for byte (#2147, #2149).

Tests crlfPasswordHasNoLineEnd (tst_filecontent),
crlfLineEndStaysOutOfThePasswordField (tst_passworddialog: unedited save
exact, a typed "!" lands in the password) and
crlfEntryCopiesThePasswordWithoutItsLineEnd (tst_mainwindow: Ctrl+C and
Always copy). Dropping the strip, the Ctrl+C change or the dialog's
write-back each fails a test. Finding PMXFHOE8.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* Password row: no second CR strip

FileContent::passwordLine() drops the carriage return of a CRLF line end
now, so the password row's own strip (from #2149) removed a second one:
for a first line "hunter2\r\r" the row showed and copied "hunter2" while
Ctrl+C and "Always copy" gave "hunter2\r". The row keeps the value as it
gets it; the line-end rule lives in one place (CodeRabbit).

passwor... (continued)

8 of 8 new or added lines in 4 files covered. (100.0%)

8588 of 8921 relevant lines covered (96.27%)

593.39 hits per line

Jobs
ID Job ID Ran Files Coverage
1 43722495310.1 15 Nov 2026 02:19PM UTC 87
96.27
GitHub Action Run
Source Files on build 43722495310
  • Tree
  • List 87
  • Changed 6
  • Source Changed 6
  • Coverage Changed 4
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #43722495310
  • 3b640434 on github
  • Prev Build on main (#43715891009)
  • Next Build on main (#43724549194)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc