• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

IJHack / QtPass / 43715891009
96%

Build:
DEFAULT BRANCH: main
Ran 15 Nov 2026 01:07PM UTC
Jobs 1
Files 87
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

15 Nov 2026 12:50PM UTC coverage: 96.268% (+0.005%) from 96.263%
43715891009

push

github

web-flow
Content search: cancelling it stops gpg (#2186)

* Content search: cancelling it stops gpg

Giving up on a content search, by emptying the search box and pressing
Return or by releasing the content search button, only reset the flags in
GrepSearchController and restored the cursor. The search runs outside the
process queue, on NativeGrep's worker thread, and nothing on those paths
called NativeGrep::cancel(): the worker went on through the store, one
gpg -d per entry, and its result was dropped at the end. A profile switch
and switching content search off in Settings take the same path, and so
does the panel autoclear leaving content search (clearPanel()). An entry
slow to decrypt kept a gpg busy for minutes after the window looked idle;
passphrase entries kept raising pinentry prompts.

Pass gets CancelGrep() (a no-op by default), which both backends route to
their NativeGrep's cancel(): the walk ends at the next entry and the
running gpg is terminated. MainWindow::cancelContentSearch() calls it on
both backends (the active one may have changed since the search started)
from all three ways out. The partial result the worker still delivers is
discarded as before.

Test cancellingAContentSearchStopsIt with a gpg stand-in that takes 30 s
per decrypt: each of the three ways out ends the search within seconds.
Removing any of the three calls, or the backend's cancel, fails it.
Finding YLQNQFUH.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* Content search: the panel autoclear leaves it as the button does

clearPanel() stopped the backends' search but left the controller with
clearGrepMode(), which keeps it busy and not cancelled. A content search
entered again before the stopped search reported then showed its partial
matches under an empty search box, and the wait cursor stayed until then.
It now leaves through leaveGrepMode() and restores the cursor, as
releasing the button does; clearGr... (continued)

10 of 11 new or added lines in 4 files covered. (90.91%)

8589 of 8922 relevant lines covered (96.27%)

590.25 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
64.29
-4.95% src/pass.h
Jobs
ID Job ID Ran Files Coverage
1 43715891009.1 15 Nov 2026 01:07PM UTC 87
96.27
GitHub Action Run
Source Files on build 43715891009
  • Tree
  • List 87
  • Changed 7
  • Source Changed 6
  • Coverage Changed 6
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #43715891009
  • 916082d3 on github
  • Prev Build on main (#43713983634)
  • Next Build on main (#43722495310)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc