• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

IJHack / QtPass / 43576377873
96%

Build:
DEFAULT BRANCH: main
Ran 14 Nov 2026 08:42AM UTC
Jobs 1
Files 127
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

14 Nov 2026 08:33AM UTC coverage: 92.726% (-0.007%) from 92.733%
43576377873

push

github

web-flow
Pass: heal the pending-insert count when the command queue drains (#2153)

insertsPending() counts the inserts awaiting a report so a PasswordDialog can
tell an earlier insert's report from its own (#2152). The count assumes every
queued insert reaches Pass::finished() once as PASS_INSERT. One path does not:
ImitatePass::finished() returns early with "No such transaction" without
reporting, and a later change could drop an insert the same way. A skipped
report would leave the count one too high for the rest of the session, so every
later dialog would take its own report for an earlier one and wait for ever,
with only "Close the dialog anyway?" as a way out.

When the executor drains — nothing runs and nothing waits — no insert is in
flight, so the count is forced back to zero in the drained handler that also
emits idle(). A lost report then heals itself at the next quiet moment. Idle
cannot fall between a dialog's insertsPending() read and its own report, since
that insert keeps the executor busy, so a live count is never cleared.

Regression test aLostInsertReportIsHealedWhenTheQueueDrains leaks one report,
runs a normal insert, and asserts the count is zero once the queue is idle.

Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

3 of 3 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

10516 of 11341 relevant lines covered (92.73%)

406.64 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
71.43
-28.57% src/imitatepass.h
Jobs
ID Job ID Ran Files Coverage
1 43576377873.1 14 Nov 2026 08:42AM UTC 127
92.73
GitHub Action Run
Source Files on build 43576377873
  • Tree
  • List 127
  • Changed 3
  • Source Changed 1
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #43576377873
  • 2d489bbc on github
  • Prev Build on main (#43575002591)
  • Next Build on main (#43582648697)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc