• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

IJHack / QtPass / 43582648697
96%

Build:
DEFAULT BRANCH: main
Ran 14 Nov 2026 10:06AM UTC
Jobs 1
Files 127
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

14 Nov 2026 09:53AM UTC coverage: 92.716% (-0.01%) from 92.726%
43582648697

push

github

web-flow
Refuse store changes while git is mid-rebase, -merge, -cherry-pick or -revert (#2154)

* Refuse store changes while git is mid-rebase, -merge, -cherry-pick or -revert

With "Use Git" on, a pull that stops in a conflict leaves the repository
part-way through an operation, and QtPass kept committing into it without a
word. Before git add/commit, ImitatePass and RealPass checked only gitReady(),
which reads settings and never the repository's state:

- A save, delete, move or copy during a stopped rebase is committed on a
  detached HEAD. It is reported as saved, but `git rebase --abort` (the command
  git's own message suggests) then removes new entries, restores edited ones to
  their old text and brings deleted ones back.
- A re-encryption during a stopped merge resolves every conflict in favour of
  the local copy and concludes the merge; with automatic push on it pushes that
  over a colleague's newer version, which then survives only in the history.

Add Pass::refuseUnfinishedGitOperation(), called at the entry of every
store-changing operation next to refuseLinkedPath(): ImitatePass Insert(),
Remove(), Move(), Copy(), Init() and reencryptPath(), and RealPass Insert(),
Remove(), Init() and passMoveOrCopy(). It asks the repository once, through a
new virtual storeGit() (ImitatePass runs the configured git with `-C <store>`,
RealPass runs `pass git`), for the path of each of rebase-merge, rebase-apply,
MERGE_HEAD, CHERRY_PICK_HEAD and REVERT_HEAD. If one exists it names the
operation ("Unfinished Git operation"), emits critical()/processErrorExit()
before gpg or pass runs — so the password dialog keeps what was typed — and the
caller stops. The re-encryption checks stop the worker before its backup
commit, so the stopped merge stays open and the remote keeps the colleague's
copy.

Nothing is refused when Git is off, the store is not a repository, or git gives
no answer. A HEAD detached by hand (looking up an old password with
`git checkout <commit>`)... (continued)

64 of 70 new or added lines in 4 files covered. (91.43%)

10577 of 11408 relevant lines covered (92.72%)

405.93 hits per line

Uncovered Changes

Lines Coverage ∆ File
3
93.32
-0.16% src/imitatepass.cpp
2
69.23
-12.59% src/pass.h
1
98.32
-0.1% src/pass.cpp
Jobs
ID Job ID Ran Files Coverage
1 43582648697.1 14 Nov 2026 10:06AM UTC 127
92.72
GitHub Action Run
Source Files on build 43582648697
  • Tree
  • List 127
  • Changed 6
  • Source Changed 6
  • Coverage Changed 6
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #43582648697
  • b2b4ba1b on github
  • Prev Build on main (#43576377873)
  • Next Build on main (#43588280146)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc