• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

IJHack / QtPass / 43575002591
96%

Build:
DEFAULT BRANCH: main
Ran 14 Nov 2026 08:24AM UTC
Jobs 1
Files 127
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

14 Nov 2026 08:16AM UTC coverage: 92.733% (-0.002%) from 92.735%
43575002591

push

github

web-flow
PasswordDialog: match each insert report to the dialog that queued it (#2152)

Since #1965 a dialog can close while its insert is still queued (a save held
up by a hanging git pull, given up through "Close the dialog anyway?"), so more
than one insert can be in flight. PasswordDialog::onInsertFinished() and
onInsertFailed() took the next Pass::finishedInsert / insertFailed that
arrived while saving as their own, on the one-insert-at-a-time assumption that
no longer holds. The result: a later dialog closed as saved on an earlier
insert's success, and if its own insert then failed (most simply a retry under
the same name) what was typed was stored nowhere; an earlier failure was shown
as a later dialog's "Not saved" for an entry that was then written.

Pass now counts the inserts that have started queueing but not yet reported:
queueInsert() is called where ImitatePass::Insert() and RealPass::Insert()
queue their work, past every refusal, and Pass::finished() counts one off per
PASS_INSERT before its result goes out, next to the m_pendingShows
bookkeeping. PasswordDialog::save() reads insertsPending() into m_insertsAhead
just before its own Insert(), and isOwnInsertReport() — the new guard of both
handlers — lets that many reports pass before taking one as the dialog's own.
This covers both directions and both backends; with no earlier insert pending
nothing changes.

Also fix ImitatePass::m_insertPlaced, which was one flag for every queued
insert: Insert() cleared it (at the moment of the click), finished() set it
only on gpg success, so a second queued insert's gpg failure was reported with
the first insert's "placed" answer (insertFailed written=true, a false "Saved,
not committed"). Clear it per dequeue in finished() instead, so the flag is the
answer of the insert whose gpg step just ended. RealPass already keeps a record
per queued insert and is unchanged.

Tests: anEarlierInsertsResultIsNotTaken / anEarlierInsertsFailureIsNotTaken
(PasswordDialog... (continued)

13 of 13 new or added lines in 4 files covered. (100.0%)

1 existing line in 1 file now uncovered.

10515 of 11339 relevant lines covered (92.73%)

406.83 hits per line

Coverage Regressions

Lines Coverage ∆ File
1
91.53
-0.85% src/nativegrep.cpp
Jobs
ID Job ID Ran Files Coverage
1 43575002591.1 14 Nov 2026 08:24AM UTC 127
92.73
GitHub Action Run
Source Files on build 43575002591
  • Tree
  • List 127
  • Changed 8
  • Source Changed 7
  • Coverage Changed 7
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #43575002591
  • 2c59fc91 on github
  • Prev Build on main (#43572608931)
  • Next Build on main (#43576377873)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc