• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

IJHack / QtPass / 43572608931
96%

Build:
DEFAULT BRANCH: main
Ran 14 Nov 2026 07:54AM UTC
Jobs 1
Files 127
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

14 Nov 2026 07:45AM UTC coverage: 92.735% (+0.005%) from 92.73%
43572608931

push

github

web-flow
Users dialog: one unreadable .gpg-id line no longer unticks every recipient (#2151)

* Users dialog: one unreadable .gpg-id line no longer unticks every recipient

UsersDialog::selectRecipients() decided which recipients to tick from a
single `gpg --list-keys` call over every .gpg-id line. gpg aborts that whole
call with exit code 2 when any one term is unreadable — a bare `0x`, a
mistyped key ID, a fingerprint one digit short or long — so it listed nothing
even though the other lines name keys that are in the keyring, and
Pass::listKeys turns a non-zero exit into an empty list. The dialog then
opened with none of the folder's real recipients ticked, next to a ticked
"Key not found in keyring" placeholder for the bad line.

That is where the recipient list gets repaired (the bad line already makes
every save in the folder fail), so the user is likely to meet it there.
Pressing OK unchanged wrote the bad line alone over .gpg-id; repairing the
list from what the dialog shows re-encrypted the folder without the other
recipients. Either way every recipient not re-ticked by hand was dropped.

When the batched call returns nothing for more than one recipient, fall back
to a per-line lookup and union the results, so the keys the readable lines
name are still ticked. The existing second loop then reports only the
unreadable line as missing, as it already does for an unknown key, and OK
writes the same lines back.

Regression test unreadableRecipientLineLeavesTheOthersTicked drives the real
dialog with a stand-in gpg that exits 2 for any call containing `0x`, as the
real one does, and asserts both keyring recipients stay ticked while only the
`0x` line is reported missing.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* Users dialog: cap the per-line recipient fallback and reuse its results

The per-line fallback added for an unreadable .gpg-id line ran one blocking
gpg call per recipient with n... (continued)

13 of 13 new or added lines in 1 file covered. (100.0%)

10506 of 11329 relevant lines covered (92.74%)

406.67 hits per line

Jobs
ID Job ID Ran Files Coverage
1 43572608931.1 14 Nov 2026 07:54AM UTC 127
92.74
GitHub Action Run
Source Files on build 43572608931
  • Tree
  • List 127
  • Changed 1
  • Source Changed 1
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #43572608931
  • 7fccb25c on github
  • Prev Build on main (#43567663894)
  • Next Build on main (#43575002591)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc