• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

IJHack / QtPass / 43567663894
96%

Build:
DEFAULT BRANCH: main
Ran 14 Nov 2026 06:50AM UTC
Jobs 1
Files 127
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

14 Nov 2026 06:42AM UTC coverage: 92.73% (+0.004%) from 92.726%
43567663894

push

github

web-flow
Content panel: don't trim leading/trailing space off the password (#2149)

* Content panel: don't trim leading/trailing space off the password

PasswordDisplayPanel::addField() ran value.trimmed() on every row, including
the Password row that displayFields() feeds the raw password line. For an
entry whose password begins or ends with a space, the panel's copy button, QR
code and shown (or eye-revealed) text all returned a password that differs
from what is stored, so logging in with it failed — while Ctrl+C on the tree,
the edit dialog and `pass show` returned the correct value. The stored entry
was untouched; one entry simply yielded two different passwords depending on
which control was used. Such entries arise naturally: QtPass's own New
password dialog and `pass insert -m` save the password exactly as typed. The
trim has applied to the password row since 2016 (first released in v1.2.0).

Keep the password row's value exactly as stored. The surrounding whitespace is
part of the password, not layout, so only a trailing CR from a CRLF-stored
entry is dropped (it is a line ending). Named `key: value` fields are still
trimmed, where the whitespace around the value is a separator.

Regression test passwordRowKeepsSurroundingWhitespace covers the shown value,
the copy payload, the eye-button line edit and the CR-stripping, and that a
named field is still trimmed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* Test: assert the password copy button payload directly

CodeRabbit: renderedText() also collects the browser's plain text, so the
substring check passed even if the copy button trimmed the value or was
absent. Compare QPushButtonWithClipboard::getTextToCopy() against the stored
value instead (clipboard enabled so the button exists).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

---------

Signed-off-by: Anne Jan Brouwe... (continued)

9 of 9 new or added lines in 1 file covered. (100.0%)

10497 of 11320 relevant lines covered (92.73%)

406.45 hits per line

Jobs
ID Job ID Ran Files Coverage
1 43567663894.1 14 Nov 2026 06:50AM UTC 127
92.73
GitHub Action Run
Source Files on build 43567663894
  • Tree
  • List 127
  • Changed 1
  • Source Changed 1
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #43567663894
  • 1b06cd06 on github
  • Prev Build on main (#43519932534)
  • Next Build on main (#43572608931)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc