Ouranosinc / xclim / 42247399040
90%

DEFAULT BRANCH: main
Ran
Jobs 0
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
42247399040

push

github

web-flow 
Numbagg required, bottleneck optional (#2461)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #2459
- [x] Tests for the changes have been ~added~ skipped (for bug fixes /
features)
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGELOG.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?
The `run_length` submodule requires `ffill` and `bfill` through xarray
which itself requires either `numbagg` or `bottleneck` in at least
certain cases that xclim needs. So if we want to remove `bottleneck`, we
need to add `numbagg`.

`numbagg` only depends on `numba` and `numpy`, which are already
dependencies, so it should be quite straightforward ?

* Moves `numbagg` to a required dependency
* Moves `bottleneck` to an optional dependency for "performance"

### Does this PR introduce a breaking change?
Some results might change when bottleneck is not available. But that was
already the case if one did `xarray.set_options(use_bottleneck=False)`,
so I'd say it's pretty minor.

As `numbagg` only has two dependencies we already have, I'm not
expecting much breaking changes in the installation of the package, but
these things can be surprising.
Source Files on build 42247399040
Detailed source file information is not available for this build.