Ouranosinc / xclim
92%

DEFAULT BRANCH: main
Repo Added
Files 60
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 92.0% (-0.003%) from 92.003%
21767596042

push

github

web-flow 
Doymin, doymax :  nan when all the same (#2314)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGELOG.rst has been updated (with summary of main changes)
- [ ] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?
Rewrite of `doymin` and `doymax`. Addition of a check to put NaN when
all the values are the same.

Also, I don't know since where this is possible, but using `idxmin` is
much simpler than `argmin` with `lazy_indexing`! I think the `dt`
accessor wasn't always available with dask.

I want to remove the special treatment in snow indicators where we first
check is any value is above 0. With this new behaviour of `doymax` , the
special treatment is unnecessary for `snd_max_doy`, for example.

This PR also has the side effect of 
- allowing all-nan slices
- return a float instead of an integer

### Does this PR introduce a breaking change?
Before a slice where all values where the same would return the doy of
the first timestamp. I think this is problematic.

10 of 10 new or added lines in 1 file covered. (100.0%)

7924 of 8613 relevant lines covered (92.0%)

6.28 hits per line

Relevant lines Covered
8613 RELEVANT LINES 7924 COVERED LINES
6.28 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
21767596042 main Doymin, doymax : nan when all the same (#2314) <!--Please ensure the PR fulfills the following requirements! --> <!-- If this is your first PR, make sure to add your details to the AUTHORS.rst! --> ### Pull Request Checklist: - [ ] This PR addre... push web-flow github
92.0
21767229782 allsame-doy-nan Merge 282613b8d into c2e2f1114 Pull #2314 web-flow github
92.0
21726163544 dev-v099 Merge branch 'main' into dev-v099 Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com> push web-flow github
92.01
21725543416 dev-v099 [new xclim] Adopt PEP-735 (Dependency groups) (#2316) ### What kind of change does this PR introduce? * Splits the `lint` dependencies into a `dependency-group` in `pyproject.toml`. * Adjusts the Makefile to silently install linting dependencies... push web-flow github
92.01
21720603674 dependency-groups Merge 5e33b76fe into 3810f4a03 Pull #2316 web-flow github
91.98
21690254034 dependency-groups Merge 2afe8fa3c into 3810f4a03 Pull #2316 web-flow github
91.98
21679363096 dependency-groups Merge 2566d4b74 into 3810f4a03 Pull #2316 web-flow github
92.01
21442480059 main Replace xclim.core.utils.VARIABLES with xclim.core.VARIABLES (#2318) ### What kind of change does this PR introduce? Fix inaccuracy in error and warning messages. ### Does this PR introduce a breaking change? No ### Other information: Clarifica... push web-flow github
92.0
21404109277 util_VARS Merge 68b170f6b into 56b667045 Pull #2318 web-flow github
91.97
21401902803 util_VARS Merge 9287dfa0c into 56b667045 Pull #2318 web-flow github
92.0
See All Builds (4933)