ruby-grape / grape / 41223761146

100%

push

github

Copy only containers between oneof variants instead of deep_dup (#3046)

OneofValidator gave each variant a deep_dup of the value, so that a variant
that fails after coercing or defaulting something doesn't leak that into the
next one. deep_dup also copies the leaves, which breaks uploads: Tempfile is a
delegator and not an Object, so Object#deep_dup is forwarded to the File it
wraps and returns a bare File. Types::File.parsed? then fails its
is_a?(Tempfile) check, and every valid upload inside a oneof variant has been
rejected with "does not match any of the allowed schemas" since oneof was
added.

Validators write by assigning into Hashes and Arrays, so copying those alone
keeps the variants isolated. This was the last call to deep_dup in Grape, so
its require goes too.

No spec pinned the isolation: the suite passed with no copy at all. Add specs
for a nested Hash coercion, an Array element coercion, a nested default and an
upload.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

1518 of 1519 branches covered (99.93%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

4533 of 4534 relevant lines covered (99.98%)

30702.48 hits per line