ruby-grape / grape / 41223413921

100%

Build Type

push

github

Committed by web-flow

Commit Message

Answer 404 when every route on a path cascades (#3043)

A route declines a request with X-Cascade: pass. The README documents the
result for an invalid version under `cascade: true`: a 404 if no other route
matches. The router only did that when one route had declined. With two or
more routes on the path, #rotation handed back the last one's response, and
since #2829 a cascading ANY route's response came back too, with its body
already closed. So an unknown version answered 404 from an API with one
version and 406 from an API with several.

Rack::Cascade goes by the status alone, so that 406 also stopped it short of
the next app, despite the X-Cascade header.

A declined response is now always closed and dropped, leaving the router's own
404, which still carries X-Cascade. An ANY route that declined still matched,
so no 405 follows it.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

1513 of 1515 branches covered (99.87%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 1 file covered. (100.0%)

8 existing lines in 2 files now uncovered.

4522 of 4531 relevant lines covered (99.8%)

15295.18 hits per line