ruby-grape / grape / 41224667323

100%

Build Type

push

github

Committed by web-flow

Commit Message

Split the router's miss and cascade paths and rename its methods (#3047)

#settle and #neighbours handled two situations, no route matching and a route
declining, and told them apart with a `cascaded` flag. That flag was true
exactly when a route had matched, so it is replaced by two paths: #after_miss
looks for the allowed methods and the ANY routes, #after_cascade tries the
siblings and the ANY routes. #halt?, a predicate that closed a body as a side
effect, goes with it.

The names said something else, so:

- `transaction` is `dispatch`: there is no atomicity or rollback in it.
- `match?`, `greedy_match?` and `neighbour_match?` return a route, so they are
  `star_route_for`, `allowed_methods_route_for` and `neighbour_route_for`.
- `GreedyRoute` is `AllowedMethodsRoute`: it matches on the path whatever the
  method, and only ever answers with the methods the path allows. Nothing in
  the ruby-grape org uses the constant outside this repo.

The two lookups that repeated `routes.detect` go through `matched_route`.

This is #3044, which merged into #3043's branch after #3043 had already merged,
so it never reached master.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

1496 of 1513 branches covered (98.88%)

Branch coverage included in aggregate %.

38 of 38 new or added lines in 3 files covered. (100.0%)

33 existing lines in 6 files now uncovered.

4498 of 4532 relevant lines covered (99.25%)

19165.74 hits per line