IJHack / QtPass / 40676746547

93%

Build Type

push

github

Committed by web-flow

Commit Message

Executor: a dequeuing() slot may call back into the executor (#2082)

* Executor: a dequeuing() slot may call back into the executor

Henk's review of #2080: executeNext() emitted dequeuing() while holding a
reference to the queue's head and before marking it running. A slot that
queued more could reallocate the queue under that reference and, with
running still false, start the same head again; one that called
cancelNext() could drop the very item being started.

The head is copied and marked running before the signal goes out, so
execute() from a slot waits behind it and cancelNext() drops nothing
(-1, as for any running head). The header says what a slot may do.

Also names where "Password encryption aborted." comes from (pass's own
die in cmd_insert and cmd_edit), for whoever looks for it next.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* Executor: cancelNext() is guarded while its dequeuing() is out too

CodeRabbit on #2082: cancelNext() emitted dequeuing(id, false) with
running false, so a slot's cancelNext() dropped the next item as well and
its execute() started one before the signal returned, against the
contract this PR documents.

running is set around that emit as in executeNext(). Nothing is started
afterwards: ImitatePass calls cancelNext() in a loop from its completion
handler to drop the rest of a failed transaction, and starting the next
item there would run a step of that transaction. The queue moves on when
the handler returns (onProcessFinished()).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

---------

Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

5 of 5 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

9617 of 10390 relevant lines covered (92.56%)

336.49 hits per line