IJHack / QtPass / 40673929941

93%

push

github

Content search preview: never half a surrogate pair (#2081)

* Content search preview: never half a surrogate pair

The 200-character window around a match could start or end inside a
surrogate pair (an emoji, CJK Extension B), leaving a lone surrogate next
to the "…". A window that starts on a low surrogate takes the high one
before it, and one that ends on a high surrogate takes the low one after.

From Henk's review of #2075.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* Content search preview: say up to two more, rewrap the changelog line

Henk's review of #2081: both edges can adjust, so the window can be two
code units longer, not one; and the CHANGELOG line is wrapped at the
width of its neighbours again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* Content search preview: say code units, claim only surrogate pairs

CodeRabbit on #2081: kMaxPreviewLength counts UTF-16 code units, not
characters; what is kept whole is a surrogate pair, not every emoji (a
ZWJ sequence or a flag can still be cut between its code points), and
the CHANGELOG says so; the test also checks the expanded size
(kMaxPreviewLength + 4: one code unit and one "…" per edge).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* tst_util: the wide-line stand-in finds its file next to itself

CodeRabbit on #2081: the script quoted the temporary path in '...', which
a TMPDIR holding a quote breaks. It reads wide.txt from its own directory
now, so no path is written into it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/sessio... (continued)

9 of 9 new or added lines in 1 file covered. (100.0%)

9613 of 10385 relevant lines covered (92.57%)

336.23 hits per line