IJHack / QtPass / 40667121198

93%

Build Type

push

github

Committed by web-flow

Commit Message

pass backend: written means a whole entry, fingerprinted when the save runs (#2080)

* pass backend: written means a whole entry, fingerprinted when the save runs

Henk's notes on #2079:

- A changed entry whose pass run said "Password encryption aborted." is
  not counted as written: gpg broke off and what it left is no entry.
  insertWritten() takes the failed insert's stderr for that.
- The "before" fingerprint is taken when the insert leaves the executor
  queue (new Executor::dequeuing, emitted synchronously for every item as
  it starts, cannot start, or is cancelled), not when it was queued: a
  second queued save of the same entry compares against what the first
  left. RealPass keeps a queue of insert targets, so inserts of different
  entries no longer share one slot either.
- The test's stand-in takes its mode from the piped value, not from an
  environment variable a failed check would have left set.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* pass backend: each insert's fingerprint goes with its own completion

An insert whose pass cannot start reports a posted error, and the next
queued item starts at once: the single target/fingerprint slot was then
the next insert's when that error was handled, so a failed start could be
credited with the next insert's write.

RealPass keeps a record (entry, fingerprint) per insert that left the
queue and has yet to complete, and takes the front one in finished() for
PASS_INSERT: completions come in the order the items left the queue.
Executor::dequeuing() now says whether a completion follows (not for an
item cancelNext() drops), so a dropped insert leaves no record behind.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

-------... (continued)

Coverage Stats

24 of 26 new or added lines in 6 files covered. (92.31%)

17 existing lines in 1 file now uncovered.

9609 of 10381 relevant lines covered (92.56%)

341.94 hits per line