IJHack / QtPass / 40662866599

93%

push

github

Deep scan fixes: recipient list folder line, bounded reads, profile-aware re-encrypt (#2075)

* Deep scan: new-profile preselect, re-encrypt profile, late decrypts

From the CodeRabbit deep scan of f5d21f83d:

- #5: a new profile's recipients dialog preselects nothing
  (UsersDialog::Preselect::Nothing): needsInit() found no list, and one
  appearing meanwhile was read under the active profile's signing policy.
- #9: ImitatePass re-encrypts also when pass is the active backend, and
  then kept the settings of the profile it last ran for. Re-encryption
  takes the current settings (when no run is active).
- #6: a decrypt arriving after the selection was cleared (deselect, a
  profile switch) no longer repaints the panel.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* Deep scan: bounded and non-blocking reads, keygen values, script regexes

From the CodeRabbit deep scan of f5d21f83d:

- #1 Totp::parse() refuses a configuration over MAX_CONFIG_LENGTH (4096)
  before QUrl/QUrlQuery turn it into millions of items.
- #4 KeygenDialog refuses a name or passphrase with CR, LF or NUL: the
  batch is line-oriented, so each would start a directive of its own.
- #7 NativeGrep keeps at most kMaxPreviewLength (200) characters of a
  matching line.
- #14 GpgIdSigner::verify() gives gpg the .gpg-id.sig path only when it
  is a regular file of at most kMaxSignatureBytes (a FIFO blocked gpg and
  the GUI thread).
- #17 ImportKeyDialog opens the picked file's target as a regular file
  without blocking (Util::openRegularFile on the canonical path).
- #11 check_skill_sanity: a link title starts with a non-blank, so no
  overlap with the separator; #15 YAML aliases in frontmatter refused
  before construction.
- #20 audit_ts: maximal Latin runs found once, neighbours checked
  directly, instead of a lookahead rescanning every suffix.

T... (continued)

61 of 66 new or added lines in 10 files covered. (92.42%)

9589 of 10359 relevant lines covered (92.57%)

342.43 hits per line