IJHack / QtPass / 40658000196

93%

push

github

pass backend: an edited entry whose commit fails is saved, not "Not saved" (#2079)

RealPass::insertWritten() counted an entry as written only when it had
not existed before the insert. With `pass insert -f` on an existing entry
whose commit then fails (pass.signcommits, no usable key), pass exits
non-zero after writing the new ciphertext, so the dialog stayed open with
"Not saved" and no "Saved, not committed" box: the case #2074 claims for
both backends.

Insert() now keeps a SHA-256 of the entry's bytes (opened as a regular
file, no link, no FIFO) and insertWritten() compares: a fresh encryption
never gives the same bytes, so a rewritten entry differs as surely as a
new one appears.

The box no longer says "git could not record it:" in front of what may be
all of pass's stderr, gpg lines included.


Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d

Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

11 of 11 new or added lines in 2 files covered. (100.0%)

9540 of 10307 relevant lines covered (92.56%)

302.62 hits per line