IJHack / QtPass / 40654945614

93%

Build Type

push

github

Committed by web-flow

Commit Message

New profile: entries under a sub-store are not counted as unencrypted (#2073)

* New profile: entries under a sub-store are not counted as unencrypted

Henk on #2072: since the count walks sub-folders, it also counted
entries under a folder with a .gpg-id of its own. Their recipients did
not change when the profile's root list was written, and Users on the
root leaves them alone, as pass does, so "not re-encrypted ... open
Users to do that" did not apply to them. They are left out now; the
comment says "visible" regular files, as the walker skips hidden ones.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* New profile: sign and commit in the configured GPG home

CodeRabbit: ProfileInit's processes ran in the plain system environment,
while every other gpg and git call of QtPass gets the configured GPG
home (Pass::init sets GNUPGHOME when that folder exists). So a new
profile's .gpg-id was signed in the default keyring, which may not hold
the signing key, and a commit git signs through gpg used it too.
withGpgHome() applies the same rule to the signer and to git; a home
that does not exist leaves the inherited GNUPGHOME, as Pass::init does.

Test: a stand-in gpg logs the GNUPGHOME it runs with; it fails with the
signer on the plain environment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* Test git's GPG home too in initialiseSignsInTheConfiguredGpgHome

CodeRabbit: the test ran without git, so gitEnvironment() was not
covered. A recording git stand-in now logs the GNUPGHOME it runs with,
and both logs must hold the configured home; with git's environment
back on the plain one, the test fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude... (continued)

Coverage Stats

41 of 41 new or added lines in 1 file covered. (100.0%)

9 existing lines in 1 file now uncovered.

9529 of 10299 relevant lines covered (92.52%)

302.65 hits per line