IJHack / QtPass / 40529500999

93%

Build Type

push

github

Committed by web-flow

Commit Message

Security scan follow-ups: plain-text names, literal pathspecs, bounded reads (#2060)

* Security scan follow-ups: plain-text names, literal pathspecs, bounded reads

From the CodeRabbit agent scan of 96c6a0fa4:

- Names from the store (entry path, field names, .templates fields, the
  rename label, the Users dialog banner) are shown as plain text; as
  rich text <img src="/dev/zero"> made Qt read that file without end.
- GIT_LITERAL_PATHSPECS=1: `git rm -f -- a*.gpg` removed every matching
  entry; git now takes each path QtPass (or pass under it) hands it as is.
- New folder creates the path it checked: "link/../x" passed the lexical
  check and was made beside the link's target.
- .gpg-id is read as a regular file of at most 1 MiB (Util::
  readRegularFile) by all three readers; key import reads at most 16 MiB.
- Re-encryption re-checks its folder after the pull.
- Keygen: a line is cut at a NUL, as gpg reads it, so "%no-protection"
  followed by one no longer slips past the passphrase splice.
- RnpCrypto caps the plaintext limit to 32 bits, as RNP stores it: 4 GiB
  became "no limit" there.
- check_skill_sanity: link regex confined to one line (was quadratic).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* check_skill_sanity: LINK_RE on one line, as super-linter's ruff wants

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* Plain text in message boxes that quote the store

Review: QMessageBox's static helpers are Qt::AutoText as well, so the
same <img src="/dev/zero"> name reached Qt's rich text through the
delete, link-removal, overwrite and re-encrypt questions and through
every Pass::critical (MainWindow::critical), the new after-pull refusal
included, which appears without a... (continued)

Coverage Stats

100 of 116 new or added lines in 14 files covered. (86.21%)

1 existing line in 1 file now uncovered.

9432 of 10200 relevant lines covered (92.47%)

303.31 hits per line