IJHack / QtPass / 40523582638

93%

Build Type

push

github

Committed by web-flow

Commit Message

#2061 follow-ups: drop the dead pass grep path, count lines as written (#2062)

Henk's non-blocking points on #2061:

- parseGrepOutput(), its header helper, handleGrepError() and the
  PASS_GREP branches in Pass::finished() go: nothing starts `pass grep`
  any more (both backends search through NativeGrep), and an unbounded
  parser behind a live signal is what the next person would wire up
  again. PASS_GREP stays in the enum for the process-name table. Its
  fourteen tests go with it.
- The edit dialog counts lines as an editor holds them: the final
  newline pass writes ends a line, it adds none, so an entry of exactly
  kMaxDisplayLines lines opens and the message gives the right number.
  kMaxDisplayLines' doc says the dialog applies it to the whole entry.
- std::numeric_limits rather than <climits>/INT_MAX, as in the rest of
  src/; the misplaced doc block in tst_passworddialog back on its test;
  the CHANGELOG paragraph reflowed.


Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d

Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

4 of 4 new or added lines in 1 file covered. (100.0%)

4 existing lines in 1 file now uncovered.

9385 of 10141 relevant lines covered (92.55%)

303.48 hits per line